Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temperature sensor support to google smarthome thermostat device #24264

Merged

Conversation

Projects
None yet
3 participants
@piitaya
Copy link
Contributor

commented Jun 2, 2019

Description:

This PR add temperature sensor devices to google_assistant smart_home component.
The TemperatureSetting trait supports attribute queryOnlyTemperatureSetting which will allow us to integrate temperature sensors.

Related issue (if applicable): fixes #22676

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9557

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • Documentation added/updated in home-assistant.io
    If the code does not interact with devices:
  • Tests have been added to verify that the new code works.

piitaya added some commits Jun 2, 2019

@@ -107,6 +108,7 @@
(binary_sensor.DOMAIN, binary_sensor.DEVICE_CLASS_OPENING): TYPE_SENSOR,
(binary_sensor.DOMAIN, binary_sensor.DEVICE_CLASS_WINDOW): TYPE_SENSOR,
(media_player.DOMAIN, media_player.DEVICE_CLASS_TV): TYPE_TV,
(sensor.DOMAIN, sensor.DEVICE_CLASS_TEMPERATURE): TYPE_THERMOSTAT,

This comment has been minimized.

Copy link
@balloob

balloob Jun 3, 2019

Member

Let's make this type sensor. And please sort alphabetically.

@balloob

balloob approved these changes Jun 3, 2019

Copy link
Member

left a comment

Awesome! One small comment to address.

@balloob balloob added this to the 0.94.0 milestone Jun 3, 2019

@balloob balloob merged commit 976bf3e into home-assistant:dev Jun 3, 2019

4 of 8 checks passed

ci/circleci: pre-install-all-requirements CircleCI is running your tests
Details
ci/circleci: pre-test 3.5.5 CircleCI is running your tests
Details
ci/circleci: pre-test 3.6 CircleCI is running your tests
Details
ci/circleci: pre-test 3.7 CircleCI is running your tests
Details
build Workflow: build
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
home-assistant Build #20190603.45 succeeded
Details

balloob added a commit that referenced this pull request Jun 3, 2019

Add temperature sensor support to google smarthome thermostat device (#…
…24264)

* Add temperature sensor support to google smarthome thermostat device

* fix lint for trait_test

* Reset temperature unit in tests

* Address comment

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.