Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add De Lijn (Flemish Public Transport) component #24265

Merged
merged 9 commits into from Jul 26, 2019

Conversation

@bollewolle
Copy link
Contributor

commented Jun 2, 2019

Breaking Change:

none

Description:

Add De Lijn (the Flemish Public Transport agency) support. The use of the API's of De Lijn does require a subscription key that needs to be added to the configuration. You can register for a free developer account at https://data.delijn.be/ where you can find the subscription key.

Works best with the following custom lovelace card: https://github.com/bollewolle/delijn-card

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9507

Example entry for configuration.yaml:

sensor:
  # De Lijn public transport
  - platform: delijn
    sub_key: 'abcdefg'
    nextpassage:
    - stop_id: '200018'
      max_passages: 5
    - stop_id: '201169'
      max_passages: 20

Replace the abcdefg with the API subscription key of De Lijn.
Stop Id's are 6 digit number that can be found at each physical stop of De Lijn in Flanders, but can also be found on their site here: https://www.delijn.be/en/haltes/

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/delijn/sensor.py Outdated Show resolved Hide resolved

@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Jul 23, 2019

bollewolle added a commit to bollewolle/home-assistant.io that referenced this pull request Jul 25, 2019

Updating the used terminology
Some updates to the documentation to reflect the changes made to PR home-assistant/home-assistant#24265.

bollewolle added some commits Jul 26, 2019

Updated pydelijn version requirement to 0.5.1 so UTC timestamps can b…
…e used instead of relative/local times.

Removed unused definition

bollewolle added some commits Jul 26, 2019

Update the self._attributes dict directly instead of replacing it
Assign ATTRIBUTION while creating the _attributes dict
Remove the ATTRIBUTION assignment in device_state_attributes as it's updated in the async_update now.
Removed a relative time attribute
Updated a linting issue in the LOGGER (used % instead of the format)

bollewolle added a commit to bollewolle/delijn-card that referenced this pull request Jul 26, 2019

Dev automation moved this from Review in progress to Reviewer approved Jul 26, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Great!

@MartinHjelmare MartinHjelmare changed the title Initial commit of De Lijn (Flemish Public Transport) component Add De Lijn (Flemish Public Transport) component Jul 26, 2019

@MartinHjelmare MartinHjelmare merged commit 0fc2813 into home-assistant:dev Jul 26, 2019

9 checks passed

CI Build #20190726.20 had test failures
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Jul 26, 2019

@balloob balloob referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.