Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deps folder in config when on Docker #24284

Merged
merged 3 commits into from Jun 3, 2019

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

commented Jun 3, 2019

Description:

Remove the deps folder when upgrading to 94b6 or beyond when running under Docker.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.94.0 milestone Jun 3, 2019

@balloob balloob requested a review from home-assistant/core as a code owner Jun 3, 2019

@pvizeli

pvizeli approved these changes Jun 3, 2019

balloob added some commits Jun 3, 2019

@balloob balloob merged commit 0b70419 into dev Jun 3, 2019

2 of 4 checks passed

build Workflow: build
Details
ci/circleci: static-check CircleCI is running your tests
Details
cla-bot Everyone involved has signed the CLA
home-assistant Build #20190603.43 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the docker-burn-deps branch Jun 3, 2019

balloob added a commit that referenced this pull request Jun 3, 2019

Remove deps folder in config when on Docker (#24284)
* Remove deps folder in config

* Fix tests

* Fix tests with docker check

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

@torarnv

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

I just installed 0.94.1 in a docker container and with a clean config dir, and ended up with an empty deps folder, shouldn't this PR prevent that from being created, or remove it if so?

@torarnv

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2019

Seems this PR only removes it when doing a config upgrade. So the question is why the folder is still created in 0.94.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.