Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Zeroconf to 0.23 #24300

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@balloob
Copy link
Member

commented Jun 4, 2019

Description:

Zeroconf 0.23 will no longer cause stacktraces if it discovers itself on a loopback network.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@codeowners-notifier

This comment has been minimized.

Copy link

commented Jun 4, 2019

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit ac788a7 into dev Jun 4, 2019

2 of 4 checks passed

build Workflow: build
Details
ci/circleci: static-check Your tests are queued behind your running builds
Details
cla-bot Everyone involved has signed the CLA
home-assistant Build #20190604.37 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the upgrade-zeroconf branch Jun 4, 2019

balloob added a commit that referenced this pull request Jun 4, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.