Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeroconf deprecated key #24302

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@Kane610
Copy link
Contributor

commented Jun 4, 2019

Description:

Address is deprecated in favour of addresses in zeroconf 0.23

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@codeowners-notifier

This comment has been minimized.

Copy link

commented Jun 4, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

@balloob balloob added this to the 0.94.0 milestone Jun 4, 2019

@balloob

balloob approved these changes Jun 4, 2019

@balloob balloob merged commit fbfaa41 into home-assistant:dev Jun 4, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing ac788a7...952eadb
Details
codecov/project 94.2% (target 90%)
Details
home-assistant Build #20190604.45 succeeded
Details

@Kane610 Kane610 deleted the Kane610:zeroconf-use-addresses branch Jun 4, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.