Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OwnTracks race condition #24303

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

commented Jun 4, 2019

Description:

When OwnTracks is set up using MQTT and the OwnTracks messages have the retain flag on, it is possible for messages to be processed before the device tracker platform has been set up.

With this PR, those messages will now get processed when the device tracker platform has been initialized.

Related issue (if applicable): fixes issue reported on Discord #beta

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit df1da75 into dev Jun 4, 2019

1 of 3 checks passed

build Workflow: build
Details
ci/circleci: static-check Your tests are queued behind your running builds
Details
cla-bot Everyone involved has signed the CLA

@delete-merged-branch delete-merged-branch bot deleted the owntracks-race-startup branch Jun 4, 2019

balloob added a commit that referenced this pull request Jun 4, 2019

Fix OwnTracks race condition (#24303)
* Fix OwnTracks race condition

* Lint

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.