Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore automation last_triggered with initial_state override #24400

Merged
merged 4 commits into from Jun 8, 2019

Conversation

@frenck
Copy link
Member

commented Jun 8, 2019

Breaking Change:

When setting the startup state of automation using the initial_state setting, it would also mean that the last_triggered attribute of the automation was lost. This behavior has been solved. It can potentially break automations if you rely on it being reset on startup.

Description:

Automations are restored from the state storage only when initial_state isn't set.
However, the last_triggered is also restored from the state storage.

The current logic, makes the last_triggered vanish when the user has set an initial_state.

This PR changes this behavior, by first trying to load the previous state from the state storage and later apply the initial_state override. This preserves the last_triggered attribute.

Related issue (if applicable): fixes #12672 (old closed, never resolved).

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@frenck frenck requested a review from home-assistant/core as a code owner Jun 8, 2019

@ghost

This comment has been minimized.

Copy link

commented Jun 8, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (automation) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob
balloob approved these changes Jun 8, 2019
Copy link
Member

left a comment

ok to merge when comment addressed

@frenck

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

ci/circleci: static-check, because of a styling issue in an unrelated file:

homeassistant/components/zha/sensor.py:24:1: E302 expected 2 blank lines, found 1

Introduced in #24373

@frenck frenck referenced this pull request Jun 8, 2019
4 of 9 tasks complete
frenck added 3 commits Jun 8, 2019

@frenck frenck force-pushed the frenck-2019-0063 branch from 2680fe6 to fdf4161 Jun 8, 2019

@frenck

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Rebased onto dev to fix build error.

state = hass.states.get('automation.hello')
assert state
assert state.state == STATE_OFF
assert state.attributes.get('last_triggered') is None

This comment has been minimized.

Copy link
@andrewsayre

andrewsayre Jun 8, 2019

Member

Are you asserting that last_triggered is not present in the dictionary or that it's present but with a value of None? This should be made tighter to verify the intended behavior... i.e. assert 'last_triggered' not in state.attributes or assert state.attributes['last_triggered'] is None.

This comment has been minimized.

Copy link
@frenck

frenck Jun 8, 2019

Author Member

The last_triggered attribute is hardcoded to be returned always in the state attributes of AutomationEntity. It will always be there, by default initialized as None.

It really won't matter, secondly, this is consistent with all other tests.
Third, the test_automation_restore_state test should cover that case IMHO, which it doesn't either.

@balloob balloob merged commit 9235b52 into dev Jun 8, 2019

1 of 3 checks passed

build Workflow: build
Details
ci/circleci: static-check Your tests are queued behind your running builds
Details
cla-bot Everyone involved has signed the CLA

@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0063 branch Jun 8, 2019

@balloob balloob referenced this pull request Jun 26, 2019
jcoin added a commit to jcoin/home-assistant that referenced this pull request Jun 29, 2019
Master (#3)
* Update azure-pipelines-release.yml for Azure Pipelines

* Bump simplipy to 3.4.2 (home-assistant#24326)

* Bump simplipy to 3.4.2

* Updated requirements

* Meteofrance fix 24244 (home-assistant#24315)

* Update meteofrance package version

Fix home-assistant#24244

* Add code owner to manifest

* Update CODEOWNERS

* Only update media icon when necessary (home-assistant#24324)

* Only update media icon when necessary

* Lint

* Comment

* components/cover: Typo in docstring. (home-assistant#24329)

* Add exception handling for Netatmo climate (home-assistant#24311)

* Add exception handling

* Make pylint happy

* Initiate websession inside event loop (home-assistant#24331)

* Remove deprecated AlarmControlPanel (home-assistant#24322)

* Use node descriptor from Zigpy for ZHA (home-assistant#24316)

* use zigpy node descriptor

* cleanup

* Add abbreviation for light template variable names (home-assistant#24336)

* Remove attribute lowBat (home-assistant#24323)

* Don't load last_checkpoint if shipment is pending (home-assistant#24301)

* UPgrade youtube_dl to 2019.05.20 (home-assistant#24347)

* Add new movement type "actively" of the Xiaomi Vibration Sensor (home-assistant#24334)

* Fix set_cover_position of the xiaomi_aqara cover for LAN protocol v2 (home-assistant#24333)

* Fix set_cover_position of the xiaomi_aqara cover for LAN protocol v2 (Closes: home-assistant#24293)

* Fix lint

* Add Environment Canada weather, sensor, and camera platforms (home-assistant#21110)

* Added Environment Canada weather platform

* Added Environment Canada weather platform

* Migrate to new folder structure

* Migrate to new folder structure

* Fix updates

* Fix updates again

* Bump env_canada to 0.0.4

* Bump env_canada to 0.0.4

* Bump env_canada to 0.0.4 in requirements_all.txt

* Change daily forecast timestamp and high/low test

* Change daily forecast timestamp and high/low test

* Bump env_canada to 0.0.5

* Break alerts into multiple sensors, bump env_canada to 0.0.6

* Bump env_canada to 0.0.7

* Remove blank line

* Remove 'ec' sensor prefix, bump env_canada to 0.0.8

* Corrections

* Change to manifests.json

* Add docstring to __init.py__

* Update CODEOWNERS

* pylint correction

* pylint correction

* Add alert details, bump env_canada to 0.0.9

* Update requirements_all.txt

* Update .coveragerc

* Bump env_canada to 0.0.10

* Update requirements_all.txt

* Google Cloud Platform component (TTS) (home-assistant#23629)

* Added Google Cloud TTS service component feature

* Added Neutral voice gender

* Added line break at the end of files

* Updated CODEOWNERS, reqirements_all.txt and .coveragerc

* Fixed some ci/circleci: static-check errors

* Fixed some ci/circleci: static-check error

* Fixed some ci/circleci: pylint errors

* Fixed some ci/circleci: pylint errors

* * made supported_options const
* fixed direct env variable access

* Fixed import order

* * Component renamed
* Added encoding parameter
* Other fixes

* Changed folder name in .coveragerc

* * Removed whitespaces in blank lines
* Split long line

* Removed whitespaces in blank lines

* ci/circleci: static-check

* Fixed requirements_all.txt

* Added speed, pitch and gain parameters

* Added speed, pitch and gain as supported options

* Split too long line

* * Added profiles parameter
* Changed supported languages and encodings values
* Added parameters validations

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Changed options validation

* Added ToggleEntity save and restore state mechanism

* Revert "Added ToggleEntity save and restore state mechanism"

This reverts commit 0e27501

* Add Streamlabs Water Monitor (home-assistant#21205)

* Add Streamlabs Water Monitor

* Fail Streamlabswater component setup when given invalid parameters

The Streamlabs Water component is unable to recover if it is given
an invalid API key or location id so this change is to ensure
we validate they are correct during setup and return a failure
if they are not.

* Prime Streamlabswater component sensors so data is available immediately

The sensors for the component were not causing an immediate load of
data from the API when being set up so there was some lag after
startup before values would show up.  This change does an explicit
update when the sensors are setup to ensure data is viewable
immediately after startup.

* Switch Streamlabswater logging to use %s for string formatting

* Update Streamlabswater component with correct dependencies

Dependencies were incorrectly specified using DEPENDS rather
than DEPENDENCIES

* Streamlabswater pull request feedback

Remove detailed class docstrings since they're in the documentation,
reduce code duplication in sensor classes, and remove periods from
the end of log messages.

* Reduce line length in Streamlabswater sensor

* Add docstring on Streamlabswater service callback method

* Get rid of unnecessary initializers in Streamlabswater sensor

* Add manifest file for Streamlabs Water Monitor

* Remove unused REQUIREMENTS

* ebusd: added check for monitored conditions validity within correct circuit (home-assistant#22461)

* Bring the Sisyphus integration to silver quality (home-assistant#22457)

* Bring the Sisyphus integration to silver quality

Checklist:
- [x] (N/A - push integration) Set an appropriate SCAN_INTERVAL (if a polling integration)
- [x] Raise PlatformNotReady if unable to connect during platform setup
- [x] (N/A - no credentials) Handles expiration of auth credentials. Refresh if possible or print correct error and fail setup. If based on a config entry, should trigger a new config entry flow to re-authorize.
- [x] (N/A - local integration) Handles internet unavailable. Log a warning once when unavailable, log once when reconnected.
- [x] Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.
- [x] Set available property to False if appropriate
- [x] Entities have unique ID (if available)

* Feedback (fix a couple verbose places)

* Use a task instead of a lock

* Initialize field in constructor

* Revert package upgrade.

* Support for Salda Smarty XV/XP Ventilation Unit (home-assistant#21491)

* Support for Salda Smarty XV/XP Ventilation Unit

* Update binary_sensor.py

* Update fan.py

* Update sensor.py

* Update __init__.py

* Bump to pypck==0.6.1 (home-assistant#24356)

* Add templating to MQTT Cover tilt_status (home-assistant#24355)

* Upgrade ruamel.yaml to 0.15.97 (home-assistant#24350)

* Upgrade ruamel.yaml to 0.15.97

* Fix req

* Bump regenmaschine to 1.5.1 (home-assistant#24358)

* Life360 integration (home-assistant#24227)

* Refactor Waze Travel Time & Update Requirements (home-assistant#22428)

* Refactor Waze Travel Time & Update Requirements

Refactored Waze Travel Time to contain a data object.

Changed error retrieving data to a warning.
Added distance conversion depending on region.
Removed dependency on TRACKABLE_DOMAINS list.
Update to use WazeRouteCalculator 0.10

3rd time's a charm.  Deleted fork, caused last PR to screw up.  So here we are.

* Update requirements_all.txt

* Revert package upgrade.

* Revert package upgrade.

* Update pyhomematic (home-assistant#24368)

* Add service to update core location (home-assistant#24328)

* Add service to update core location

* Update test_init.py

* Fix ZHA battery level when value is reported via signal (home-assistant#24371)

* fix battery signal
* review comment

* Remove binary sensors for ZHA remotes and controllers (home-assistant#24370)

* remove remote binary sensor profiles
* fix contact sensors

* Add support for ZHA door locks #2 (home-assistant#24344)

* Add support for DoorLock cluster
* Add test for zha lock
* Change lock_state report to REPORT_CONFIG_IMMEDIATE
* Update channel command wrapper to return the entire result
This allows for return values other than result[1]

* Fix tests
* Fix lint
* Update DoorLock test to work with updated zigpy schema
* Fix lint
* Fix unlock test

* Create azure-pipelines-ci.yml

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Bump dependency (home-assistant#24376)

* Upgrade discord.py to 1.1.1 (home-assistant#24375)

* Upgrade Mastodon.py to 1.4.3 (home-assistant#24374)

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Add shuffle support for itunes component (home-assistant#24319)

* added shuffle support for itunes component

* fixed pylint errors

* more pylint

* final pylint (have my own dev env now)

* Fixed wrong setpoint value on startup when climate was previously turned off (home-assistant#24377)

* Add ATTR_FORECAST_PRECIPITATION option (home-assistant#24308)

* Add ATTR_FORECAST_PRECIPITATION option

* Remove blank line

* Provide an option for the DD-WRT device tracker to include non-wireless devices (home-assistant#24259)

* Use LAN status instead of wireless status for DD-WRT device tracking

* Use the previous DD-WRT device tracker behavior unless specified in the configuration

* Updated pubnubsub-handler to 1.0.7 to fix crash on slow startup (home-assistant#24388)

* Add for option for template triggers (home-assistant#24330)

* Improve amcrest error handling and bump amcrest package to 1.5.3 (home-assistant#24262)

* Improve amcrest error handling and bump amcrest package to 1.5.3

amcrest package update fixes command retry, especially with Digest Authentication, and allows sending snapshot command without channel parameter.

Get rid of persistent_notification.

Errors at startup, other than login errors, are no longer fatal.

Display debug messages about how many times an error has occurred in a row.

Remove initial communications test. If camera is off line at startup this just delays the component setup.

Handle urllib3 errors when getting data from commands that were sent with stream=True.

If errors occur during camera update, try repeating until it works or the camera is determined to be off line.

Drop channel parameter in snapshot command which allows camera to use its default channel, which is different in different camera models and firmware versions.

Make entities unavailable if too many errors occur in a row.

Add new configuration variables to control how many errors in a row should be interpreted as camera being offline, and how frequently to "ping" camera to see when it becomes available again.

Add online binary_sensor option to indicate if camera is available (i.e., responding to commands.)

* Update per review comments

Remove max_errors and recheck_interval configuration variables and used fixed values instead.

Move definition of AmcrestChecker class to module level.

Change should_poll in camera.py to return a fixed value of True and move logic to update method.

* Improve boolean validator (home-assistant#24294)

* Improve boolean validator

* Remove extra throw

* Remove None test as discussed

* Fix for tests depending on None == False

* Add more HomeKit models for discovery (home-assistant#24391)

* Add more HomeKit models for discovery

* Discover Tradfri with HomeKit

* Add Wemo device info

* Allow full match for HomeKit model

* Fix tests

* Fix automation failing to restore state (home-assistant#24390)

* Fix automation off

* Fix tests

* Check cloud trusted proxies (home-assistant#24395)

* add device class to sensors (home-assistant#24373)

* Fix for sun issues (home-assistant#24309)

* deCONZ - properly identify configured bridge (home-assistant#24378)

* Bump version to 0.95.0.dev0

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Fixes linter warning in ZHA sensor (home-assistant#24406)

* Use loose version (home-assistant#24394)

* deCONZ fix retry set state(home-assistant#24410)

* Restore automation last_triggered with initial_state override (home-assistant#24400)

* Restore automation last_triggered with initial_state override

* Made test async/await

* Fixes linter warning

* Update test_init.py

* Fix recorder defaults (home-assistant#24399)

* Fix recorder defaults

* Address comment

* Minor improvements to automation test suite (home-assistant#24424)

* Minor improvements to automation test suite

* Removes unused asyncio imports

* Removes some vars that are not needed

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Update azure-pipelines-ci.yml for Azure Pipelines

* Upgrade broadlink library (home-assistant#24450)

* Upgrade ambiclimate library (home-assistant#24449)

* Rename via_hub to via_device (home-assistant#24360)

* Rename via_hub to via_device

* Fixed registry interactions

* Load the SSDP component only when it's needed (home-assistant#24420)

* fix(hue): Load the SSDP component only when it's needed

* fix(deconz): Don't load the SSDP component when it's not needed

* Update config_flow.py

* Update test_config_flow.py

* Axis discovery MAC filter (home-assistant#24442)

* Make sure to abort if the MAC is not from Axis

* Fix tests

* Andrew Sayre suggestion

Co-Authored-By: Andrew Sayre <6730289+andrewsayre@users.noreply.github.com>

* Remove frequest asuswrt log spam (home-assistant#24448)

* Publish test results (home-assistant#24460)

* Life360: Fix config entry handling for accounts imported from configuration (home-assistant#24455)

Was improperly generating a warning each restart.

Was not properly handling a password change in configuration.

Was not properly removing config entries for accounts removed from configuration.

* Remember gpslogger entities across restarts (fixes home-assistant#24432) (home-assistant#24444)

* Remember gpslogger entities across restarts (fixes home-assistant#24432)

* oops, missed those changes

* Remove to do and set defaults to `None`

* Add default config to constaint file (home-assistant#24423)

* Add websock command to query device for triggers (home-assistant#24044)

* Add websock command to query device for triggers

* Lint

* Refactor

* Add support for domain automations

* Make device automation an automation platform

* lint

* Support device_id in light trigger

* Review comments

* Add tests

* Add tests

* lint

* Sun listener to adapt to core config updates (home-assistant#24464)

* Adaptable sun listener

* Lint

* Update Hass.io when core config is updated (home-assistant#24461)

* Update Hass.io when core config is updated

* Lint

* Fix tests

* Lint sigh

* Uber API is going away on June 13, 2019, remove component (home-assistant#24468)

* Uber API is going away on June 13, 2019, remove component

* Update CODEOWNERS

* Remove Uber component

* Use met.no instead of yr.no in default config (home-assistant#24470)

* Bump pyubee to 0.7 to support more models (home-assistant#24477)

* Bump pyubee to 0.7 to support more models

* Update requirements_all.txt

* Somfy open api (home-assistant#19548)

* CREATE Somfy component

* CREATE cover Somfy platform

* USE somfy id as unique id

* UPDATE all the devices in one call to limit the number of call

* FIX Don't load devices if not yet configured

* IMP Replace configurator by a simple notification

* ADD log in case state does not match

* IMP wording

* REMOVE debug stuf

* ADD support for tilt position

* UPDATE requirements

* FIX Use code instead of authorization response

 - Will allow to setup Somfy without https

* HANDLE stateless devices (Somfy RTS)

* FIX import locally 3rd party library

* UPDATE pymfy to 0.4.3

* ADD missing docstring

* FIX For Somfy 100 means closed and 0 opened

* FIX position can be None

* ENHANCE error management when error 500 occurs at setup

* FIX indent

* ROLLBACK tilt modification

 - See https://community.home-assistant.io/t/somfy-tahoma-official-api/61448/90?u=tetienne

* FIX Look for capability instead of state

* DON'T use exception to test if a feature is available

* UPDATE dependency

* ADD device_info property

* AVOID object creation in each method

* REMOVE unused constants

* ADD missing doc

* IMP Only make one call to add_entities

* USE dict[key] instead of get method

* IMP Don't pass hass object to the entities

* FIX Don't end logging messages with period

* USE config entries instead of a cache file

* IMPLEMENT async_unload_entry

* CONSOLIDATE package

 - see home-assistant/architecture#124

* UPDATE to pymfy 0.5.1

* SIMPLIFY config flow

* ADD French translation

* FIX 80 vs 79 max length

* ABORT flow asap

* FIX A tupple was returned

* MIGRATE to manifest.json

* ADD a placeholder async_setup_platform coroutine

 - It's currently required and expected by the platform helper.

* FIX codeowner

* ADD missing translations file

* USE new external step

* UPGRADE pymfy version

* Close Somfy tab automatically

* ADD manufacturer

  - Somfy only for the moment.

* HANDLE missing code or state in Somfy request

* REMOVE unused strings

* DECLARE somfy component to use config_flow

* APPLY static check remarks

* FIX async method cannot be called from sync context

* FIX only unload what has been loaded during entry setup

* DON't catch them all

* DON'T log full stacktrace

* ABORT conflig flow if configuration missing

* OMIT Somfy files for coverage

* ADD tests about Somfy config flow

* ADD pymfy to the test dependencies

* Add APRS device tracker component (home-assistant#22469)

* Add APRS device tracker component

This component keeps open a connection to the APRS-IS infrastructure so
messages generated by filtered callsigns can be immediately acted upon.
Any messages with certain values for the 'format' key are position
reports and are parsed into device tracker entities.

* Log errors and return if startup failure

* Fix unit tests

* Add Linky sensors : yesterday + months + years (home-assistant#23726)

* Add Linky sensors : yesterday + months + years

- SCAN_INTERVAL to 4 hours
- Always close_session after getting the data
- Add username attr
- Fix not updating Linky sensor when Enedis API fails

* Fix @balloob review: remove monitored_conditions

* Add attributs and fix lightlevel inconsistency for LightLevel sensor (home-assistant#24439)

* Add attributs and fix state level

* Update sensor.py

* Update sensor.py

* Support ZLO device types to support newer Zigbee devices in ZHA (home-assistant#24429)

* Support ZLO device types
Support the device types that are added in zigpy/zigpy#176
so newer Zigbee devices can be supported.

* Remove BINARY_SENSOR mappings
* Add back ON_OFF_LIGHT_SWITCH, DIMMER_SWITCH and COLOR_DIMMABLE_LIGHT
Since they are target devices I've added them as switch and lights,
which matches the Zigbee documentation.

* Upgrade to zigpy-homeassistant v0.5.0
To be able to use the new DeviceTypes

* Camera platform for buienradar imagery (home-assistant#23358)

* Add camera for buienradar radar

* Use asyncio.Conditions instead of asyncio.Lock

* Add test and fix python 3.5 compatibility

* rename interval to delta for consistency with BOM integration

* fix linting error introduced during rebase

* Improved buienradar.camera documentation and tests

  * Incorporated one comment on a redundant/cargo cult function
  * Improved documentation
  * Increase test coverage by fixing one test by making it a coroutine
    (to make it actually run), adding another test case, and changing
    the flow in the implementation.

* style changes after review, additional test case

* Use python 3.5 style mypy type annotations in __init__

* Remove explicit passing of event loop

* Adopt buienradar camera as codeowner

* Update manifest.json

* Update CODEOWNERS through hassfest

Updated CODEOWNERS through hassfest (instead of manually), thanks to
@balloob for the hint.

* Position is reversed for horizontal awnings (home-assistant#23257)

* Position is reversed for awnings

* Changed device class function to use map

* It wanted more linebreak

* Updated defaults

* Shortened line

* space

* Fix aprs imports (home-assistant#24485)

* Version bump for toonapilib to include new API call for fetching thermostat states, which was sometimes missing causing errors in the library (home-assistant#24459)

* Update hass-nabucasa to 0.14 (home-assistant#24481)

* Update hass-nabucasa to 0.14

* Update owner of cloud

* Update codeowners

* remove docs from config entries file [skip ci] (home-assistant#24488)

* Bump adguardhome to 0.2.1 (home-assistant#24486)

Signed-off-by: Franck Nijhof <frenck@addons.community>

* Fix owntracks source_type for location messages with default trigger (home-assistant#24503)

Some location update messages do not contain the 't' (trigger) key. Before the change in 0.94 to
entity based trackers, these would default to source_type of 'gps' (due to default parameter
value in async_see method.) To mirror this behavior in the new entity based tracker, the
source_type property should default to SOURCE_TYPE_GPS under the same conditions.

* Add Cast discovery to manifest (home-assistant#24504)

* Bump pyatmo to 2.00 (home-assistant#24505)

* Bump pyatmo version to 1.13

* Bump to 2.00

* Fix version number

* missing comma preventing other voices (home-assistant#24487)

* Migrate HEOS discovery to manifest (home-assistant#24508)

* Migrate HEOS discovery to manifest

* Fix tests

* Bumping Keenetic NDMS2 client to 0.0.8 (home-assistant#24469)

Fixing issue with long strings in Telnet response

* Update DelugeClient to 1.7.1 (home-assistant#24518)

* Update DelugeClient to 1.7.1 

Due to update of Deluge to 2.0.3

* deluge-client==1.7.1 in requirements_all.txt

* Clean up Alexa smart home code (home-assistant#24514)

* Clean up Alexa smart home code

* lint

* Lint

* Lint

* Remove conversation from default config (home-assistant#24515)

* Refactor yeelight code (home-assistant#22547)

* Separate yeelight light classes

* Removed not used variable

* Allow to create device right away, when model is declared

* Lint fixes

* Use correct brightness, when nightlight mode is on

* Pylint fix

* Add power property

* Fix imports

* Update homeassistant/components/yeelight/light.py

Co-Authored-By: Teemu R. <tpr@iki.fi>

* Small PR fixes

* Simplify device to yeelight class mapping

* Simplify device initialization code

* Fix comment

* Migrate Sonos discovery to manifest (home-assistant#24507)

* Cloud: allow managing Alexa entities via UI (home-assistant#24522)

* Clean up Alexa config

* Cloud: Manage Alexa entities via UI

* Add tests for new cloud APIs

* WIP Ps4 Convert entity to Async / Fix entity name changing (home-assistant#24101)

* Convert ps4 to async

* Init client handler.

* Add PS4_DATA

* Move data class

* add handler

* add import

* Update __init__.py

* Change most functions to async

* bump 0.8.0

* bump 0.8.0

* bump 0.8.0

* Pylint

* whitespace

* Rewrite to use asyncio sockets.

* Remove unneeded log

* Add alias

* Update __init__.py

* Update config_flow.py

* Add alias

* Add search_all method

* Clean up

* whitespace

* change comment

* 0.8.2

* 0.8.2

* 0.8.2

* Pylint

* pylint

* faster updates

* Avoid scheduling update if state is the same.

* Better handling remove search all

* deCONZ - Change attribute Watts to W (home-assistant#24535)

* Improve stability of netatmo sensor (home-assistant#24190)

* Improve stability of netatmo sensor

* Improve stability of netatmo sensor

* Improve stability of netatmo sensor

* netatmo, except timeout

* netatmo, except timeout

* netatmo, except timeout

* netatmo, except timeout

* Always release lock

* Update meteoalertapi to 0.1.5 (home-assistant#24528)

* PS4  bump to 0.8.3 (home-assistant#24527)

* 0.8.3

* 0.8.3

* 0.8.3

* add unsubscribe method

* Update translations

* Updated frontend to 20190614.0

* Pyyaml5.1 (home-assistant#24529)

* Migrated to PyYAML 5.1

* More intelligent fixing of yaml safe_load

Based on https://circleci.com/gh/home-assistant/home-assistant/34831?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

* Added name to sensors (home-assistant#24525)

* Added name to sensors

Added name to sensors, should allow for multiple devices.

This should fix home-assistant#22571 and home-assistant#21591

* Update sensor.py

Fixed spelling issue, and line too long

* Update sensor.py

Removed _ as it is a friendly name

* Update requirement version and add switcher_kis services (home-assistant#23477)

* Update aioswitcher requirement to 2019.4.26.

* Removed unnecessary legacy function call.

* Fixed log message capital first letter.

* Replaced None argument with empty dict.

* Replaced guard.

* Added ServiceCallType.

* Added set_auto_off and update_device_name services to the component.

* Added test cases for service calls.

* Conditioned the component services registry with the platform discovery.

* Update homeassistant/components/switcher_kis/__init__.py

Co-Authored-By: TomerFi <tomer.figenblat@gmail.com>

* Update homeassistant/components/switcher_kis/__init__.py

Co-Authored-By: TomerFi <tomer.figenblat@gmail.com>

* Resolved change requests.

* Added ContextType.

* Addes permission verification for service calls.

* Added test cases for permision verification and more.

* Replaced POLICY_CONTROL with the more suited POLICY_EDIT.

* More appropriate function name.

* Added domain and entity_id validation for calling services.

* Removed service for setting the vendor's device name.

* Flux switch (home-assistant#24542)

* Updated to pytest

* Additional test case

* UniFi simplify update (home-assistant#24304)

* Fix incomfort issue home-assistant#24478 & bump client (home-assistant#24548)

* fix issue home-assistant#24478 - missing climate entities

* bump client

* Handle stacktrace when rtorrent host is unreachable (home-assistant#24541)

* Fix a bug with Ambient PWS reconnection (home-assistant#24540)

* Update __init__.py (home-assistant#24553)

Fix the broken charging status

* Update ambiclimate library (home-assistant#24562)

* Misc. ZHA enhancements (home-assistant#24559)

* add nwk to device info
* input bind only cluster support
* cleanup channel only clusters
* dirty hack to correct xiaomi vibration sensor
* exclude remaining remote binary sensors
* review comments
* fix comment

* Update pysonos to 0.0.15 (home-assistant#24565)

* Whitelist yeelight predefined effects per device type (home-assistant#24544)

* Whitelist yeelight predefined effects per device type

* Fix support color

* Battery attribute & accuracy filter (home-assistant#24277)

* Extract const to a const file, Add battery as tracker attribute, add accuracy filter option

* Update homeassistant/components/traccar/device_tracker.py

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Update homeassistant/components/traccar/device_tracker.py

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Update homeassistant/components/traccar/device_tracker.py

Use [] syntax for keys that are in the validated data.

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Fix indentation

* Fix zeroconf migration messing up ESPHome discovery (home-assistant#24578)

* Bump androidtv to 0.0.16 (home-assistant#24576)

* Bump androidtv to 0.0.16

* Bump androidtv to 0.0.16

* Added percent to the disk,memory and swap percent labels (home-assistant#24575)

* SMA sensor: Add optional path (home-assistant#24558)

* Fix geniushub issue home-assistant#24530 (via a client bump) & handle edge cases (home-assistant#24546)

* bump client library to workaround home-assistant#24530

* bump client library to workaround home-assistant#24530 2/2

* bump client library to workaround home-assistant#24530

* bump client library to workaround home-assistant#24530 2/2

* bugfix: ghost devices cause TypeError: 'NoneType' object is not subscriptable

* bugfix: broken HW zones cause AttributeError: 'GeniusZone' object has no attribute 'temperature'

* delint

* Add sensitivity and sensitvity_max attributs for binary sensor (home-assistant#24438)

* Add sensitivity ans sensitvity_max attributs for binary sensor

* Update binary_sensor.py

* Update binary_sensor.py

* Update binary_sensor.py

* Update binary_sensor.py

* Cloud: Add Alexa report state (home-assistant#24536)

* Cloud: Add Alexa report state

* Lint

* Lint

* Only track state changes when we are logged in

* Added toggle service to covers (home-assistant#23198)

* Added toggle service to cover

* Added toggle tilt service and tilt closed property

* Added is_tilt_closed so tilt can be toggled

* Added toggle services

* Added toggle tilt service

* Removed spaces

* Added tests for tilt services

* Updated tests

* Added range conversion in comparison

* Added tests to cover broken areas

* Fixed open/close tilt values and added toggle function

* Added default toggle behavior using tilt_position of 0, reverted other changes

* blank space

* Added constants and swapped assert comparisons

* Fixed attribute name

* Added mqtt responses in test

* Added constants

* Space

* Fix tilt_optimistic flag being ignored if status topic set

* Added more tests

* Changed async toggle call

* Updated group tilt test

* Updated format of asserts

* Updated states calls

* Updated function variables

* merge fixes

* Added blank line

* Changed calls to async

* More async updates

* Added invert_percent configuration for zwave rollershutter (home-assistant#23101)

* Added invert_percent configuration for zwave rollershutter

* Added invert_percent configuration for zwave rollershutter

* Fix typo in zwave default configuration

* Add code_arm_required to manual alarm with MQTT (home-assistant#22641)

* add code_arm_requited to manual-mqtt alarm

* Add fix for alarm front end more-info-alarm_control_panel

* Fix code mistake

* Add code_arm_required to manual alarm (home-assistant#22618)

* Add code_arm_required to manual alarm

* Add fix for alarm front end more-info-alarm_control_panel

* Add source selection to Samsung TV media player (home-assistant#22612)

* add source selection

* return generic list

* remove useless timeout

* Fix test

* Add test for select_source

* Add negative source test

* Change order

* Arghhh

* Add hass object

* Simplify source list

Co-Authored-By: escoand <escoand@users.noreply.github.com>

* Fix alarm control panel tests (home-assistant#24586)

* Adds integration for Plaato Airlock (home-assistant#23727)

* Adds integration for Plaato Airlock

* Updates codeowners and coveragerc

* Fixes lint errors

* Fixers lint check error

* Removed sv translation file

* Adds en translation file

* Sets config flow to true in manifest

* Moves config flow and domain to seperate files

* Fixes lint errors

* Runs hassfest to regenerate config_flows.py

* Adds should poll property and fixes for loop

* Only log a warning when webhook data was broken

* Fixes static test failure

* Moves state update from async_update to state prop

* Unsubscribes the dispatch signal listener

* Update sensor.py

* Fix honeywell issue home-assistant#18932  (home-assistant#24402)

* change us-based default temps to Fahrenheit

* update CODEOWNERS

* update CODEOWNERS

* tweak docstring

* tweak docstring

* Coerce Fahrenheit Temps to int

* Bump base Somfy MyLink library version (home-assistant#24587)

* Better pairing for Xiaomi devices in ZHA (home-assistant#24564)

* better xiaomi pairing
* cleanup.

* ESPHome config flow only connect when needed (home-assistant#24593)

* ESPHome config flow only connect when needed

* Lint

* ESPHome load platforms lazily (home-assistant#24594)

* Add ESPHome event generation and user-defined service array support (home-assistant#24595)

* Add ESPHome event generation and user-defined service array support

* Comments

* Lint

* Fix validator for lcn.send_keys service (home-assistant#24580)

* Fix validator for lcn.send_keys service

* Removed lowercase table names from send_keys and lock_keys validators

* Revert lowercase regex.

* Fixed table name regex.

* Updated frontend to 20190618.0

* Update translations

* Cloud: Make sure on_connect forwards platform only once (home-assistant#24582)

* Make sure on_connect forwards platform only once

* Make sure right handler

* Add config entry for Met.no (home-assistant#24608)

* Add config entry for Met.no

* Fixed tests

* Notify Alexa when exposed entities change (home-assistant#24609)

* Update pysonos to 0.0.16 (home-assistant#24607)

* check for None state in broadlink (home-assistant#24589)

* Queensland bushfire alert feed platform (home-assistant#24473)

* initial version of qfes bushfire geolocation platform

* removed all occurrences of legally protected names; using new georss library

* regenerated codeowners

* fixed pylint

* added one more valid category

* moved library import to top and ran isort

* Fixed issue home-assistant#24335 (home-assistant#24612)

* Add incomfort sensor and binary_sensor (home-assistant#23812)

* Initial commit - add sensors to incomfort

* improve temp heuristics

* remove self._hass

* device_state_attributes shoudln't be None

* bump client

* refactor to reduce duplication of attributes

* refactor binary_sensor to simplify

* refactor binary_sensor to simplify 2

* delint

* fix rebase regression

* small refactor

* delint

* remove DEVICE_CLASS for CV pressure

* tidy up exception handling

* delint

* fix exception handling

* use differnt icon for boiler temp

* Add support for opencv wheels (home-assistant#24620)

* tellstick: Add socat to package dependencies (home-assistant#24531)

Otherwise the tellstick component will fail when used with a
remote host running tellcore-net.

Fixes home-assistant#24113

* Tolerance configuration for dlib_face_identify (home-assistant#24497)

* Adding tolerance configuration support for dlib_face_identify component

* Fix tolerance parameter

* Fix static-check

* Fix flake8 check

* Fix circleci tests

* Changes for improve maintainability

* Change type of confidence option

* Fix sending update when not logged in (home-assistant#24624)

* Fix sending update when not logged in

* Fix test

* Uses signal dispatcher to invoke state update (home-assistant#24627)

* Add weather alert sensor to meteo france component (home-assistant#23128)

* Quick & Dirty weather alert integration

* Add attributes in weather alert sensor.

* MeteoFranceUpdate returns dept to init the alert watcher

* add rain forecast to weather attribute

* Add checks when no weather alert data are available

* Improve date and state when online source is unreachable

* update to take into account new API of vigilancemeteo 3.0.0

* Clean local patchs and put requirements in manfiest.json

* Use only one proxy for weather alerts to avoid too much HTTP requests

* linting and comments style corrections

* Add error catching and debug logging

* Correction following PR checklist

 * Add code owners
 * Update requirements_all.txt

* Comment style

* Update CODEOWNERS after rebaseline with dev branch

* update requirements_all.txt

* Set up Met during onboarding (home-assistant#24622)

* Set up Met during onboarding

* Lint

* Add pyMetNo to test reqs

* Added ELV PCA 301 smart emeter switch (home-assistant#23300)

* added pca

* removed req from py

* try to fix codeowners

* redo req

* ran codeowners

* processed comments

* fix style

* fix style

* fix style

* Set availalbe to False when communication fails.

* Add missing init file

* Updated frontend to 20190619.0

* Update translations

* Bumped version to 0.95.0b0

* Updated frontend to 20190620.0

* Vlc telnet (home-assistant#24290)

* Vlc telnet first commit

First functional version, remains to add more functionality.

* New functions added and bugfixes

* Compliance with dev checklist

* Compliance with dev checklist

* Compliance with pydocstyle

* Removed unused import

* Fixed wrong reference for exception

* Module renamed

* Fixed module rename in other

* Fixed wrong reference for exception


Module renamed


Fixed module rename in other

* Update homeassistant/components/vlc_telnet/media_player.py

Accepted suggestion by @OttoWinter

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Update homeassistant/components/vlc_telnet/media_player.py

Accepted suggestion by @OttoWinter

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Update homeassistant/components/vlc_telnet/media_player.py

Accepted suggestion by @OttoWinter

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Update homeassistant/components/vlc_telnet/media_player.py

Accepted suggestion by @OttoWinter

Co-Authored-By: Otto Winter <otto@otto-winter.com>

* Suggestions by @OttoWinter

+Manage error when the VLC dissapears to show status unavailable.

* Removed error log, instead set unavailable state

* Changes suggested by @pvizeli

-Import location
-Use of constants

* Implemented available method

* Improved available method

* Fix device tracker see for entity registry entities (home-assistant#24633)

* Add a test for see service gaurd

* Guard from seeing devices part of entity registry

* Await registry task early

* Lint

* Correct comment

* Clean up wait for registry

* Fix spelling

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* Fix spelling

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* Bump ZHA dependencies. (home-assistant#24637)

* Upgrade blinkpy==0.14.1 for startup bugfix (home-assistant#24656)

* Update LIFX brightness during long transitions (home-assistant#24653)

* Warn when user tries run custom config flow (home-assistant#24657)

* Bump pysmartthings (home-assistant#24659)

* Prefere binary with wheels (home-assistant#24669)

* Bumped version to 0.95.0b1

* Update azure-pipelines-release.yml for Azure Pipelines

* Updated frontend to 20190624.0

* Allow extra js modules to be included in frontend (home-assistant#24675)

* Add extra_module_url and extra_module_url_es5 to frontend options

* Address review comments

* Fix time expression parsing (home-assistant#24696)

* ZHA fix device type mappings (home-assistant#24699)

* Bump version pyatmo to 2.0.1 (home-assistant#24703)

* Extend websocket method usage to port 8002 in Samsung TV media player (home-assistant#24716)

* Update ZHA dependencies (home-assistant#24718)

* update deps and remove legacy constants bridge

* run deps script and fix test import

* Add show_as_state options to Life360 (home-assistant#24725)

* Bumped version to 0.95.0b2

* Save cached logi_circle tokens in config folder (home-assistant#24726)

Instead of the working directory, which it's doing currently. Matches pattern observed on Abode, Ring, Skybell integrations.

* Update ZHA dependencies. (home-assistant#24736)

* AdGuard to update entry (home-assistant#24737)

* Update pysonos to 0.0.17 (home-assistant#24740)

* Bumped version to 0.95.0b3

* Updated frontend to 20190624.1

* Clean up Google Config (home-assistant#24663)

* Clean up Google Config

* Lint

* pylint

* pylint2

* Fix locative device update (home-assistant#24744)

* Add a test for two devices

* Fix locative updating all devices

* Add a guard clause that checks if correct device is passed.

* Improve Alexa error handling (home-assistant#24745)

* Bumped version to 0.95.0b4

* Updated frontend to 20190626.0

* Bump pyatmo to v2.1.0 (home-assistant#24724)

* Handle timeouts gracefully (home-assistant#24752)

* Update Waze route dependency to 0.10  (home-assistant#24754)

* Update manifest.json

Update waze calculator to 0.10, this was supposed to have been done in home-assistant#22428 but was missed. See discussion [here](https://community.home-assistant.io/t/waze-travel-time-update/50955/201)

* Update requirements_all.txt

* Ignore duplicate tradfri discovery (home-assistant#24759)

* Ignore duplicate tradfri discovery

* Update name

* Return correct name for met.no (home-assistant#24763)

* Bumped version to 0.95.0

* Fix life360 exception when no location provided (home-assistant#24777)

* Pubnub to 1.0.8 (home-assistant#24781)

* Catch uncaught Alexa error (home-assistant#24785)

* Bumped version to 0.95.1

* Fix netatmo weatherstation setup error  (home-assistant#24788)

* Check if station data exists and reduce calls

* Fix module names list

* Add warning

* Remove dead code

* Update azure-pipelines-release.yml for Azure Pipelines (home-assistant#24800)

* Make sure entity config is never none (home-assistant#24801)

* Bump ZHA quirks module (home-assistant#24802)

* bump quirks version

* bump version - mija magnet

* Fix another Life360 bug (home-assistant#24805)

* Fix calling empty script turn off (home-assistant#24827)

* Bumped version to 0.95.2

* Alexa sync state report (home-assistant#24835)

* Do a sync after changing state reporting

* Fix entity config being None

* Bumped version to 0.95.3

* Improve autodiscovered yeelights model detection (home-assistant#24671)

* Improve autodiscovered yeelights model detection

* Lint fixes

* Logger warn fix

* Guard for None entity config (home-assistant#24838)

* Bumped version to 0.95.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.