Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move totalconnect from platform to component config #24427

Merged
merged 27 commits into from Jul 14, 2019

Conversation

@austinmroczek
Copy link
Contributor

commented Jun 8, 2019

Breaking Change:

Total Connect Client was upgraded to support more than one alarm panel and allow future support for additional sensors. Previous alarm_control_panel entries must be removed, and a new totalconnect entry must be added to configuration.yaml. See https://www.home-assistant.io/components/totalconnect/ for configuration details.

Description:

Move toward multi-platform for Total Connect. Support multiple alarm panels. Changed totalconnect so we can add additional platforms moving forward. Moved the total_connect_client into init so a single instance will be shared across platforms. It should now allow for multiple alarm panels.

Related issue (if applicable):
craigjmidwinter/total-connect-client#26

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#
home-assistant/home-assistant.io#9589

Example entry for configuration.yaml (if applicable):

totalconnect:
    username: !secret totalconnect_username
    password: !secret totalconnect_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [n/a] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • [n/a] Tests have been added to verify that the new code works.

austinmroczek added some commits Apr 14, 2019

Added extra states for STATE_ALARM_TRIGGERED to allow users to know if
it is a burglar or fire or carbon monoxide so automations can take
appropriate actions.  Updated TotalConnect component to handle these new
states.
Catch details of alarm trigger in state attributes.
Also bumps total_connect_client to 0.27.

austinmroczek added some commits Jun 29, 2019

@MartinHjelmare MartinHjelmare changed the title Move toward multi-platform for Total Connect. Support multiple alarm panels. Move totalconnect from platform to component config Jun 30, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

Please extend the breaking change paragraph and explain in more detail what the user needs to do to cope with the breaking change. We don't need to explain the config options. It's ok to reference the docs for those.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

.coveragerc needs to be updated. We can use a star * to mark the whole totalconnect package as excluded from coverage calculation.

@austinmroczek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

@MartinHjelmare thanks for the detailed code review. I made updates per your guidance, changed .coveragerc and expanded the breaking change notes.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

There's only some small fixes left needed here.

@austinmroczek

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Sorry I’ve been away. Should finish up this weekend

@MartinHjelmare
Copy link
Member

left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit 369e6a3 into home-assistant:dev Jul 14, 2019

9 checks passed

CI Build #20190714.1 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pytlint) FullCheck Pytlint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@balloob balloob referenced this pull request Aug 7, 2019

Merged

0.97.0 #25756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.