Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update to buienradar json api; and additional monitored_conditions #24463
The following sensor types (monitored_conditions) are no longer supported, since they are no longer provided by the json api of buienradar:
The following monitored conditions will change unit:
Switching over to new version of python-buienrader (1.0.1); this version now leverages the new json buienradar-api. This API provides new sensor data to home-assistant:
Forecast data (Weather component) will now also contain:
Related issue (if applicable):
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
referenced this pull request
Jun 10, 2019
Seems we have 2 owners in one component now (@mjj4791 for sensor/weather and @ties for the camera component in buienradar). However I am unable to convince my update/commit to manifest and codeowners to get accepted...
@mjj4791 I think this is similar to what happened when Paulus added me as as a codeowner in the manifest. I think that the linter that checks that that
I think that is generated by
Not on a machine with a dev environment at the moment so I can not check.
It seems to pass the checks but it has merge errors. I rebased the branch from dev, skipping empty commits. Doing that and force pushing should make this mergeable.
edit: to clarify, I will not create a PR for this and can't edit this pr.
If we do documentation changes, it would be nice to include the buienradar camera, turns out I never got that into the documentation (oops).