Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keba charging station/wallbox as component #24484

Merged
merged 28 commits into from Aug 19, 2019

Conversation

@dannerph
Copy link
Contributor

commented Jun 11, 2019

Description:

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9616

Example entry for configuration.yaml (if applicable):

keba:
  host: 192.168.178.2
  rfid: XXXXXXXX
  failsafe: True
  failsafe_timeout: 30
  failsafe_fallback: 10
  failsafe_persist: 0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Hi @dannerph,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@dannerph dannerph force-pushed the dannerph:keba-charging-station branch 2 times, most recently from ba9e31d to b3f9965 Jun 11, 2019

@dannerph dannerph changed the title Add Keba charging station/wallbox as component WIP: Add Keba charging station/wallbox as component Jun 15, 2019

@petzlux

This comment has been minimized.

Copy link

commented Jul 1, 2019

Just a note to say that I will look forward to using your component, at the moment I integrate my Keba P30 through some awkward Node-Red scripting !

@dannerph

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Just a note to say that I will look forward to using your component, at the moment I integrate my Keba P30 through some awkward Node-Red scripting !

Nice to hear this!

You could test my implementation by copying the content of the "keba" folder from "homeassistant/component/keba" (e.g. from my forked repo) to "[your Home Assistant config folder]/custom_components/keba". Then you need to add at least the following lines to your config file:

keba:
  host: 192.168.178.2
  rfid: XXXXXXXX

The integration automatically creates all relevant sensors and switches. that can be easily found with the prefix "keba_".

If you provide me with feedback or ideas for improvement, I can work on it. It might also speed up the PR acceptance, if another user successfully tested the code.

dannerph added 14 commits Jul 18, 2019

@dannerph dannerph force-pushed the dannerph:keba-charging-station branch from 1f8b4f2 to 3e53460 Aug 8, 2019

homeassistant/components/keba/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/keba/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/keba/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/keba/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/keba/__init__.py Outdated Show resolved Hide resolved
dannerph and others added 7 commits Aug 8, 2019
Update homeassistant/components/keba/__init__.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Update homeassistant/components/keba/__init__.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Update homeassistant/components/keba/__init__.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Update homeassistant/components/keba/__init__.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
@dannerph

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Update: The integration is running stable in my environment (BMW Wallbox) and was successfully tested on a KEBA P30x by Erik73 in the forum.

https://community.home-assistant.io/t/evse-keba-p30-integration/52571/7

@MartinHjelmare
Copy link
Member

left a comment

Can be merged when last comment is addressed and build passes.

homeassistant/components/keba/__init__.py Outdated Show resolved Hide resolved

Dev automation moved this from Review in progress to Reviewer approved Aug 19, 2019

Update homeassistant/components/keba/__init__.py
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

@MartinHjelmare MartinHjelmare merged commit 75e18d4 into home-assistant:dev Aug 19, 2019

11 checks passed

CI Build #20190819.22 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 0fa1e3a...a381282
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants
You can’t perform that action at this time.