Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time delta option when searching for deutsche_bahn connections #24600

Merged
merged 5 commits into from Jun 27, 2019

Conversation

@h3ndrik
Copy link
Contributor

commented Jun 18, 2019

Breaking Change:

None

Description:

Add another option 'offset' to search for upcoming connections in the future.
Handy if you need a few minutes to get to the train station and need to add that to the queried departure time.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9647

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: deutsche_bahn
    from: Essen HBf
    to: Düsseldorf HBf
    offset: '00:10:00'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Add time delta option when searching for connections
Add another option 'in' to search for upcoming connections in the future.
Handy if you need a few minutes to get to the train station and need to add that to the queried departure time.
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Hi @h3ndrik,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

h3ndrik added 2 commits Jun 18, 2019
@h3ndrik h3ndrik referenced this pull request Jun 18, 2019
2 of 2 tasks complete
h3ndrik added 2 commits Jun 18, 2019
@h3ndrik

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

thank you for the suggestions. i hope it's okay it took me several commits.

@pvizeli pvizeli merged commit e932fc8 into home-assistant:dev Jun 27, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 2e848c3...ea2f3b7
Details
codecov/project 94.15% (target 90%)
Details
mxworm added a commit to mxworm/home-assistant that referenced this pull request Jun 28, 2019
Merge branch 'dev' into current
* dev: (102 commits)
  Fix netatmo weatherstation setup error  (home-assistant#24788)
  Changed default encoding to mp3 (home-assistant#24808)
  Updated frontend to 20190627.0
  Use step from tado rather than assuming 0.1 (home-assistant#24807)
  Use climate device's target temp step value (home-assistant#24804)
  Fix another Life360 bug (home-assistant#24805)
  Zestimate fix for issue home-assistant#23837 (home-assistant#23838)
  Bump ZHA quirks module (home-assistant#24802)
  Make sure entity config is never none (home-assistant#24801)
  Update azure-pipelines-release.yml for Azure Pipelines (home-assistant#24800)
  Add time delta option when searching for deutsche_bahn connections (home-assistant#24600)
  Catch uncaught Alexa error (home-assistant#24785)
  Upgrade pytest to 4.6.3 (home-assistant#24782)
  Pubnub to 1.0.8 (home-assistant#24781)
  Fix life360 exception when no location provided (home-assistant#24777)
  Upgrade vallox to async client API (home-assistant#24774)
  Entity to handle updates via events (home-assistant#24733)
  Bumped version to 0.95.0
  Return correct name for met.no (home-assistant#24763)
  Ignore duplicate tradfri discovery (home-assistant#24759)
  ...
@balloob balloob referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.