Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config entry for Met.no #24608

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@bachya
Copy link
Contributor

commented Jun 18, 2019

Description:

This PR adds a config flow for the Met.no weather integration.

Related issue (if applicable): fixes #24511

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@bachya bachya requested a review from balloob Jun 18, 2019

@bachya bachya requested a review from Danielhiversen as a code owner Jun 18, 2019

@bachya bachya self-assigned this Jun 18, 2019

@ghost ghost assigned Danielhiversen Jun 18, 2019

@ghost

This comment has been minimized.

Copy link

commented Jun 18, 2019

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (met) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob
Copy link
Member

left a comment

Amazing, thanks !! 🎉

@bachya bachya removed the request for review from Danielhiversen Jun 18, 2019

@bachya bachya merged commit a89c8ee into home-assistant:dev Jun 18, 2019

11 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@bachya bachya deleted the bachya:met-config-flow branch Jun 18, 2019

@balloob balloob referenced this pull request Jun 26, 2019
@S-Przybylski

This comment has been minimized.

Copy link

commented Jun 28, 2019

dear all,
I have configured the platform met. Since 0.95.0 i get the information that the platform is deprecated.
The documentation does not give any hint about that.
What does that mean?

File reference: homeassistant/components/met/weather.py line 36

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jun 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.