Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component VersaSense #24619

Merged
merged 18 commits into from Nov 19, 2019
Merged

Conversation

@flamm3blemuff1n
Copy link
Contributor

flamm3blemuff1n commented Jun 19, 2019

Description:

New integration for VersaSense MicroPnP devices.

The devices consist of a gateway and multiple hubs with sensors and actuators. See: VersaSense. The component connects with the gateway for communication using pyversasense.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9658

Example entry for configuration.yaml (if applicable):

versasense:
  host: GATEWAY_URI

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Jun 19, 2019

Hi @flamm3blemuff1n,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@flamm3blemuff1n flamm3blemuff1n mentioned this pull request Jun 19, 2019
2 of 2 tasks complete
homeassistant/components/versasense/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/switch.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/switch.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/switch.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/switch.py Outdated Show resolved Hide resolved
homeassistant/components/versasense/switch.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Jul 23, 2019
@flamm3blemuff1n flamm3blemuff1n force-pushed the flamm3blemuff1n:versasense branch from 2540527 to 0708c7a Aug 4, 2019
@flamm3blemuff1n

This comment has been minimized.

Copy link
Contributor Author

flamm3blemuff1n commented Aug 4, 2019

Sorry about those last couple commits. I was not aware of the new tool "black" and was still testing according the current dev documentation 0.96.0.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Aug 31, 2019

@flamm3blemuff1n are you planning to continue here? Otherwise please close this PR and you can reopen yourself when you're ready to finish. We're trying to decrease our open PR buffer. Thanks!

@flamm3blemuff1n

This comment has been minimized.

Copy link
Contributor Author

flamm3blemuff1n commented Aug 31, 2019

@MartinHjelmare Yes, I am planning to work on it this week. Sorry for the radio silence, I was busy with other projects and work.

@flamm3blemuff1n flamm3blemuff1n force-pushed the flamm3blemuff1n:versasense branch from 97c1a4b to 5196e0f Sep 5, 2019
@flamm3blemuff1n flamm3blemuff1n force-pushed the flamm3blemuff1n:versasense branch from 5196e0f to a4a6023 Sep 13, 2019
@flamm3blemuff1n flamm3blemuff1n force-pushed the flamm3blemuff1n:versasense branch from a4a6023 to 988643a Sep 27, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good. Just some small comments left.

@flamm3blemuff1n flamm3blemuff1n force-pushed the flamm3blemuff1n:versasense branch from 86b6ff5 to bb3bb93 Sep 30, 2019
Dev automation moved this from Review in progress to Reviewer approved Nov 19, 2019
@MartinHjelmare MartinHjelmare merged commit 475c8eb into home-assistant:dev Nov 19, 2019
9 checks passed
9 checks passed
CI Build #20190930.52 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Nov 19, 2019
tetienne added a commit to tetienne/home-assistant that referenced this pull request Nov 22, 2019
* Add component VersaSense

* Updates based on review

* Changes based on review

* Fixed whitespace

* Fixed lines too long

* Fixed lines too long

* Formatted using black

* Added available property

* Set unavailable property appropriately

* Conversion to f-strings

* Load platform only once per platform

* Fixed duplicate identifiers across multiple devices

* Single call to async_add_entities during setup

* Removed unnecessary async/await syntax

* Added constants for key-value pairs

* Removed async/await syntax

* Added breaks in measurement check

* Added guard clause for discovery_info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.