Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Notion Home Monitoring #24634

Merged
merged 31 commits into from Jul 9, 2019

Conversation

@bachya
Copy link
Contributor

commented Jun 19, 2019

Description:

This PR adds support for Notion Home Monitoring sensors. This PR does not automatically discover new sensors; that will come in a future PR.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9665

Example entry for configuration.yaml (if applicable):

notion:
  username: !secret notion_email
  password: !secret notion_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@bachya bachya self-assigned this Jun 19, 2019

@bachya bachya referenced this pull request Jun 20, 2019
2 of 2 tasks complete

@bachya bachya force-pushed the bachya:notion branch from a99b06a to 5730872 Jun 28, 2019

@bachya bachya changed the title Add support for Notion Home Monitoring WIP: Add support for Notion Home Monitoring Jun 28, 2019

@bachya bachya changed the title WIP: Add support for Notion Home Monitoring Add support for Notion Home Monitoring Jun 28, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

This looks great ! There a couple of small tweaks, especially look up dicts will clean up the code a lot

@balloob balloob added the almost-done label Jul 1, 2019

@bachya bachya force-pushed the bachya:notion branch 2 times, most recently from 92abbd5 to 37a796d Jul 2, 2019

@bachya bachya referenced this pull request Jul 4, 2019
5 of 5 tasks complete

bachya added some commits Jun 19, 2019

bachya added some commits Jun 28, 2019

Ugh

@bachya bachya force-pushed the bachya:notion branch from 855b8fa to 3cc14c2 Jul 5, 2019

bachya added some commits Jul 5, 2019

@balloob

balloob approved these changes Jul 8, 2019

Copy link
Member

left a comment

ok to merge when final comment addressed !

@MartinHjelmare
Copy link
Member

left a comment

Nice!

@MartinHjelmare MartinHjelmare merged commit c2e843c into home-assistant:dev Jul 9, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.19%)
Details
codecov/project 94.19% (target 90%)
Details

@bachya bachya deleted the bachya:notion branch Jul 11, 2019

@balloob balloob referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.