Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IDs for rename node/value #24646

Merged
merged 3 commits into from Jul 1, 2019

Conversation

@Swamp-Ig
Copy link
Contributor

commented Jun 20, 2019

Description:

Adds update_ids parameter to the rename_node and rename_value services. When true, these will rename any associated entities and devices with the node/value so they get the new name and new entity ID.

This needs some adjustment in the front end to make use of it, which will be in a separate PR.

Currently each node is a device, and each value is an entity. The entity IDs and names are based off the node and value names, and have defaults based on the device hardware which is not always useful.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Swamp-Ig Swamp-Ig requested a review from home-assistant/z-wave as a code owner Jun 20, 2019

@ghost

This comment has been minimized.

Copy link

commented Jun 20, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Swamp-Ig Swamp-Ig requested a review from home-assistant/core as a code owner Jun 22, 2019

@Swamp-Ig

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

I've changed how this works so that the devices and entities get renamed, rather than just removing and re-adding.

This will need a small change to the device registry though, you can currently update the name_by_user field, but not the default name.

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:zwave-rename branch from 61b8e2e to f25a928 Jun 22, 2019

Swamp-Ig added 3 commits Jun 20, 2019

@Swamp-Ig Swamp-Ig force-pushed the Swamp-Ig:zwave-rename branch from f25a928 to 5fc46fd Jun 22, 2019

@balloob
balloob approved these changes Jul 1, 2019
Copy link
Member

left a comment

Looks good!

Eventually we should move these services to websocket commands. There is no use case for device admin to be done via automation.

@balloob balloob merged commit 23dd644 into home-assistant:dev Jul 1, 2019

11 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
@Swamp-Ig

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Hang on, I wasn't quite ready to merge. Will finalise tomorrow when I have time to do it.

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jul 2, 2019
Merge branch 'dev' into current
* dev: (55 commits)
  Updated frontend to 20190702.0
  Add ability to send attachments in pushover notifications (home-assistant#24806)
  Add missing trigger.for variable to template trigger (home-assistant#24893)
  Fix 'same state' monitoring in state trigger (home-assistant#24904)
  Fix 'same state' monitoring in numeric_state trigger (home-assistant#24910)
  Stability improvements for Sonos availability (home-assistant#24880)
  Update devcontainer.json
  Update devcontainer.json
  Update devcontainer.json
  Bump life360 package to 4.0.1 (home-assistant#24905)
  Add git editor / app port
  Update IDs for rename node/value (home-assistant#24646)
  go back to signals and no hard entity references (home-assistant#24894)
  Update tts.py (home-assistant#24892)
  Support mqtt discovery topic prefix with slashes (home-assistant#24840)
  Tweak geniushub battery icons according to device state (home-assistant#24798)
  Upgrade pytest to 5.0.0 (home-assistant#24885)
  Bump androidtv to 0.0.17 (home-assistant#24886)
  Updated frontend to 20190630.0
  Update translations
  ...
Swamp-Ig added a commit to Swamp-Ig/home-assistant that referenced this pull request Jul 3, 2019
@Swamp-Ig Swamp-Ig referenced this pull request Jul 3, 2019
5 of 5 tasks complete
amelchio added a commit that referenced this pull request Jul 7, 2019
KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 8, 2019
Merge branch 'hive_water_heater' of github.com:Rendili/home-assistant…
… into hive_water_heater

* 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits)
  Sensibo, add HVAC_MODE_OFF (home-assistant#25016)
  Add support for arcam fmj receivers (home-assistant#24621)
  Enphase envoy individual inverter production (home-assistant#24445)
  Implement Twilio SMS notify MediaUrl support (home-assistant#24971)
  Climate 1.0 (home-assistant#23899)
  Correct socket use in cert_expiry platform (home-assistant#25011)
  Added missing yeelight models mapping (home-assistant#24963)
  Install requirements for integrations in packages before importing them. (home-assistant#25005)
  Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765)
  Upgrade hdate==0.8.8 (home-assistant#25008)
  upgrade switchmate to latest lib (home-assistant#25006)
  Test dependency updates (home-assistant#25004)
  Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809)
  Sleepiq single sleeper crash (home-assistant#24941)
  Changes as per code review of home-assistant#24646 (home-assistant#24917)
  Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998)
  Adds Stale Probot for issues (home-assistant#24985)
  Adds Lock Threads Probot (home-assistant#24984)
  Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821)
  Fix errors if rest source becomes unavailable (home-assistant#24986)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/climate.py
@balloob balloob referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.