Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering #24765

Merged
merged 7 commits into from Jul 7, 2019

Conversation

@teharris1
Copy link
Contributor

commented Jun 25, 2019

Description:

This PR adds a feature to turn on and off an INSTEON scene. These are different than HA scenes as they are hardware based. The underlying library is upgraded to 0.16.0 to enable INSTEON scenes and also fixes the issue with dimmers showing as on level 1 regardless of dimming level.

Related issue (if applicable): fixes #21997

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9692

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@teharris1 teharris1 referenced this pull request Jun 25, 2019
2 of 2 tasks complete
teharris1 added 2 commits Jun 29, 2019
homeassistant/components/insteon/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/insteon/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/insteon/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/insteon/__init__.py Outdated Show resolved Hide resolved
@MartinHjelmare
Copy link
Member

left a comment

Looks great!

homeassistant/components/insteon/__init__.py Outdated Show resolved Hide resolved
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 0595fc3 into home-assistant:dev Jul 7, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing dc89499...58ac0fc
Details
codecov/project 94.12% (target 90%)
Details
KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 8, 2019
Merge branch 'hive_water_heater' of github.com:Rendili/home-assistant…
… into hive_water_heater

* 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits)
  Sensibo, add HVAC_MODE_OFF (home-assistant#25016)
  Add support for arcam fmj receivers (home-assistant#24621)
  Enphase envoy individual inverter production (home-assistant#24445)
  Implement Twilio SMS notify MediaUrl support (home-assistant#24971)
  Climate 1.0 (home-assistant#23899)
  Correct socket use in cert_expiry platform (home-assistant#25011)
  Added missing yeelight models mapping (home-assistant#24963)
  Install requirements for integrations in packages before importing them. (home-assistant#25005)
  Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765)
  Upgrade hdate==0.8.8 (home-assistant#25008)
  upgrade switchmate to latest lib (home-assistant#25006)
  Test dependency updates (home-assistant#25004)
  Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809)
  Sleepiq single sleeper crash (home-assistant#24941)
  Changes as per code review of home-assistant#24646 (home-assistant#24917)
  Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998)
  Adds Stale Probot for issues (home-assistant#24985)
  Adds Lock Threads Probot (home-assistant#24984)
  Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821)
  Fix errors if rest source becomes unavailable (home-assistant#24986)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/climate.py

@teharris1 teharris1 deleted the teharris1:dev branch Jul 9, 2019

@balloob balloob referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.