Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use step from tado rather than assuming 0.1 #24807

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@andersonshatch
Copy link
Contributor

commented Jun 27, 2019

Description:

Use the device specific step value from tado when present rather than assuming it will be 0.1.
Smart thermostats use 0.1, radiator thermostats 1.0

Example entry for configuration.yaml (if applicable):

tado:
  username:
  password:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@balloob
Copy link
Member

left a comment

Awesome, thanks !

@balloob balloob merged commit c498691 into home-assistant:dev Jun 27, 2019

11 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
mxworm added a commit to mxworm/home-assistant that referenced this pull request Jun 28, 2019
Merge branch 'dev' into current
* dev: (102 commits)
  Fix netatmo weatherstation setup error  (home-assistant#24788)
  Changed default encoding to mp3 (home-assistant#24808)
  Updated frontend to 20190627.0
  Use step from tado rather than assuming 0.1 (home-assistant#24807)
  Use climate device's target temp step value (home-assistant#24804)
  Fix another Life360 bug (home-assistant#24805)
  Zestimate fix for issue home-assistant#23837 (home-assistant#23838)
  Bump ZHA quirks module (home-assistant#24802)
  Make sure entity config is never none (home-assistant#24801)
  Update azure-pipelines-release.yml for Azure Pipelines (home-assistant#24800)
  Add time delta option when searching for deutsche_bahn connections (home-assistant#24600)
  Catch uncaught Alexa error (home-assistant#24785)
  Upgrade pytest to 4.6.3 (home-assistant#24782)
  Pubnub to 1.0.8 (home-assistant#24781)
  Fix life360 exception when no location provided (home-assistant#24777)
  Upgrade vallox to async client API (home-assistant#24774)
  Entity to handle updates via events (home-assistant#24733)
  Bumped version to 0.95.0
  Return correct name for met.no (home-assistant#24763)
  Ignore duplicate tradfri discovery (home-assistant#24759)
  ...
@balloob balloob referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.