Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aurora ABB Powerone solar photovoltaic inverter #24809

Merged
merged 13 commits into from Jul 7, 2019

Conversation

@davet2001
Copy link
Contributor

commented Jun 27, 2019

Description:

Adding support for Aurora ABB Powerone solar photovoltaic inverter, providing a live power generation sensor. Communication is done via RS485.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9703

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: aurora_abb_powerone
    rs485: '/dev/serial/by-id/usb-FTDI_FT232R_USB_UART_A50285BI-if00-port0'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link

commented Jun 27, 2019

Hi @davet2001,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

davet2001 added some commits Jun 28, 2019

Delete README.md
Website documentation contains setup instructions.  README not needed here.
@davet2001

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Done from my point of view now. Not sure how to request a re-review.

Show resolved Hide resolved homeassistant/components/aurora_abb_powerone/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/aurora_abb_powerone/sensor.py
})


def setup_platform(hass, config, add_devices, discovery_info=None):

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jul 4, 2019

Member

Please rename add_devices to add_entities.

This comment has been minimized.

Copy link
@davet2001

davet2001 Jul 4, 2019

Author Contributor

Ok, but also custom_components/example_sensor/sensor.py should be updated in that case.

This comment has been minimized.

Copy link
@davet2001

davet2001 Jul 4, 2019

Author Contributor

Updated in e72db09

Show resolved Hide resolved homeassistant/components/aurora_abb_powerone/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/aurora_abb_powerone/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/aurora_abb_powerone/sensor.py Outdated

davet2001 and others added some commits Jul 4, 2019

@pvizeli

pvizeli approved these changes Jul 7, 2019

@pvizeli pvizeli merged commit 6e24b52 into home-assistant:dev Jul 7, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 69089da...1c29658
Details
codecov/project 94.13% (target 90%)
Details

@davet2001 davet2001 deleted the davet2001:aurora_abb_powerone2 branch Jul 7, 2019

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 8, 2019

Merge branch 'hive_water_heater' of github.com:Rendili/home-assistant…
… into hive_water_heater

* 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits)
  Sensibo, add HVAC_MODE_OFF (home-assistant#25016)
  Add support for arcam fmj receivers (home-assistant#24621)
  Enphase envoy individual inverter production (home-assistant#24445)
  Implement Twilio SMS notify MediaUrl support (home-assistant#24971)
  Climate 1.0 (home-assistant#23899)
  Correct socket use in cert_expiry platform (home-assistant#25011)
  Added missing yeelight models mapping (home-assistant#24963)
  Install requirements for integrations in packages before importing them. (home-assistant#25005)
  Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765)
  Upgrade hdate==0.8.8 (home-assistant#25008)
  upgrade switchmate to latest lib (home-assistant#25006)
  Test dependency updates (home-assistant#25004)
  Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809)
  Sleepiq single sleeper crash (home-assistant#24941)
  Changes as per code review of home-assistant#24646 (home-assistant#24917)
  Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998)
  Adds Stale Probot for issues (home-assistant#24985)
  Adds Lock Threads Probot (home-assistant#24984)
  Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821)
  Fix errors if rest source becomes unavailable (home-assistant#24986)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/climate.py

@balloob balloob referenced this pull request Jul 17, 2019

Merged

0.96.0 #25205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.