Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fortigate integration #24908

Merged
merged 12 commits into from Jul 16, 2019

Conversation

@kifeo
Copy link
Contributor

commented Jul 2, 2019

Breaking Change:

None

Description:

Add Fortigate integration using async code

Home-assistant.io PR : home-assistant/home-assistant.io#9807

Example entry for configuration.yaml:

# Example configuration.yaml entry
fortigate:
  host: <host_IP>
  username: homeassistant
  password: <api_key>
  devices: 
    - dev1
    - dev2

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link

commented Jul 2, 2019

Hi @kifeo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@kifeo kifeo force-pushed the kifeo:fortigate_integration branch 8 times, most recently from 8499da4 to e8633bd Jul 3, 2019

@fabaff
Copy link
Member

left a comment

Just some comments to get the review started.

homeassistant/components/fortigate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/fortigate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/fortigate/README.md Outdated Show resolved Hide resolved
homeassistant/components/fortigate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/fortigate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/fortigate/device_tracker.py Outdated Show resolved Hide resolved

@kifeo kifeo force-pushed the kifeo:fortigate_integration branch from 393c650 to 2938e79 Jul 8, 2019

@kifeo kifeo referenced this pull request Jul 8, 2019
2 of 2 tasks complete

@kifeo kifeo changed the title Add Fortigate integration WIP : Add Fortigate integration Jul 10, 2019

@kifeo kifeo changed the title WIP : Add Fortigate integration Add Fortigate integration Jul 11, 2019

@kifeo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

I would like some help regarding this failing test : test 3.7

Thanks !

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Please rebase on latest dev branch to let the build pass.

@MartinHjelmare
Copy link
Member

left a comment

Great!

Can be merged when last comment is addressed and build passes.

@kifeo kifeo force-pushed the kifeo:fortigate_integration branch from 88f4455 to 94d9139 Jul 12, 2019

kifeo added some commits Jul 2, 2019

kifeo added some commits Jul 9, 2019

@kifeo kifeo force-pushed the kifeo:fortigate_integration branch from 94d9139 to 04f9ec8 Jul 12, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

Try rebasing on latest dev branch to let the build pass.

fabaff added some commits Jul 16, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Thanks @fabaff! 👍

@fabaff

fabaff approved these changes Jul 16, 2019

@fabaff fabaff merged commit 3d3dd05 into home-assistant:dev Jul 16, 2019

9 checks passed

CI Build #20190716.15 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pytlint) FullCheck Pytlint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@lock lock bot locked and limited conversation to collaborators Jul 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.