Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing yeelight models mapping #24963

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@cadavre
Copy link
Contributor

commented Jul 5, 2019

Breaking Change:

No breaking changes.

Description:

Adds support for missing yeelight models.

Related issue (if applicable):

Fixes #24962

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist
@ghost

This comment has been minimized.

Copy link

commented Jul 5, 2019

Hey there @rytilahti, @zewelor, mind taking a look at this pull request as its been labeled with a integration (yeelight) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@zewelor

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

lamp1 is whitetemp for sure, not mono ? Its possible to set_mode to nightlight on it ?

@cadavre

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

lamp1 is WhiteTemp for sure, I have one.

It is not possible to yeelight.set_mode to nightlight on it, because this service have no nightlight mode allowed to set as mode:

Parameter Description
entity_id Name of the light entity.
mode Operation mode. Valid values are 'last', 'normal', 'rgb', 'hsv', 'color_flow', 'moonlight'.

PS On the other hand flows work perfectly.

@zewelor

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Sorry does mode moonlight works on it. For effects I've recently whitelisted effets, that are supported on non color light, does they work on this lamp ?

@zewelor

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

For me it looks good.

@aidbish

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

can you update the issue number is fixes, as it points to a different one (missing 2 at the end by looks of it)

@cadavre

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

moonlight works ok, however binary_sensor..._nightlight is not updated – just as before refactor.

By whitelisted effects you mean just "Slow temp"? No, it does nothing or I noticed nothing.

@aidbish thanks for spotting, somehow 2 got eaten.

@zewelor

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Its not updated because it reads model specs from https://gitlab.com/stavros/python-yeelight/blob/master/yeelight/main.py#L37 . It would require to add model also there and update python-yeelight.

@cadavre

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

So I'm leaving this to you.

I'm bringing yeelight functionality to point where it was before refactor on HA site.

@MartinHjelmare MartinHjelmare changed the title Added missing yeelight models mapping Add missing yeelight models mapping Jul 7, 2019

@rytilahti

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

So, if I'm reading it correctly, this fixes a known issue without breaking anything, so I think this should get merged. Not updating the nightlight state is another issue, which can be solved in a separate PR.

Thanks for the PR @cadavre and thanks @zewelor for your insight on how to fix that another issue!

@rytilahti rytilahti merged commit 31d7b70 into home-assistant:dev Jul 8, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c814b39...7d8292d
Details
codecov/project 94.19% (target 90%)
Details
KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 8, 2019
Merge branch 'hive_water_heater' of github.com:Rendili/home-assistant…
… into hive_water_heater

* 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits)
  Sensibo, add HVAC_MODE_OFF (home-assistant#25016)
  Add support for arcam fmj receivers (home-assistant#24621)
  Enphase envoy individual inverter production (home-assistant#24445)
  Implement Twilio SMS notify MediaUrl support (home-assistant#24971)
  Climate 1.0 (home-assistant#23899)
  Correct socket use in cert_expiry platform (home-assistant#25011)
  Added missing yeelight models mapping (home-assistant#24963)
  Install requirements for integrations in packages before importing them. (home-assistant#25005)
  Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765)
  Upgrade hdate==0.8.8 (home-assistant#25008)
  upgrade switchmate to latest lib (home-assistant#25006)
  Test dependency updates (home-assistant#25004)
  Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809)
  Sleepiq single sleeper crash (home-assistant#24941)
  Changes as per code review of home-assistant#24646 (home-assistant#24917)
  Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998)
  Adds Stale Probot for issues (home-assistant#24985)
  Adds Lock Threads Probot (home-assistant#24984)
  Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821)
  Fix errors if rest source becomes unavailable (home-assistant#24986)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/climate.py

@lock lock bot locked and limited conversation to collaborators Jul 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.