Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spotify service to allow to play music from playlist #24991

Conversation

@lealoureiro
Copy link
Contributor

commented Jul 6, 2019

Description:

Adding new custom service play_playlist to start playing a Spotify playlist.

This custom service allows an extra parameter random_song, from default media_player.media_play to allow select a random music at start.

Example of usage:

- service: spotify.play_playlist
  data_template:
    media_content_id: 'spotify:playlist:2ixmMpm2kRTv40a5vtb'
    random_song: true

Suggestions for better naming accepted !

Architecture discussion

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#9798

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@MartinHjelmare MartinHjelmare changed the title adding service to Spotify component to allow to play a music from playlist Add spotify service to allow to play music from playlist Jul 7, 2019

@lealoureiro lealoureiro force-pushed the lealoureiro:spotify_play_random_music_from_playlist_service branch from 2cc4b05 to a3af1a3 Jul 7, 2019

@lealoureiro

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

It is possible to retry checks again?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Try to rebase the branch on latest dev branch.

@lealoureiro lealoureiro force-pushed the lealoureiro:spotify_play_random_music_from_playlist_service branch from a3af1a3 to b2f4016 Jul 9, 2019

lealoureiro added some commits Jul 6, 2019

@lealoureiro lealoureiro force-pushed the lealoureiro:spotify_play_random_music_from_playlist_service branch from b2f4016 to 03afc9b Jul 15, 2019

@MartinHjelmare
Copy link
Member

left a comment

Nice!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit dcb12a9 into home-assistant:dev Jul 16, 2019

9 checks passed

CI Build #20190715.24 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pytlint) FullCheck Pytlint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@lock lock bot locked and limited conversation to collaborators Jul 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.