Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[climate] Bugfix honeywell misleading error message #25048

Merged
merged 12 commits into from Jul 10, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Jul 9, 2019

Breaking Change:

Description:

Whilst testing this integration, I was getting a misleading error message. This PR addresses that issue.

The client library is declaring an API rate limit exceeded when, instead, there are invalid user credentials.

This is not an ideal fix (the client library should be corrected). However, the issue was reported on the client library's repo over 2 years ago, kk7ds/somecomfort#6, and nothing has been done about it since then.

Note that this issue would have always been there & is - strictly speaking - not caused by the climate-1.0 migration.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

zxdavb added some commits Jul 9, 2019

@zxdavb zxdavb changed the title [climate] Bugfix honeywell migration [climate] Bugfix honeywell misleading error message Jul 9, 2019

@frenck frenck added the climate label Jul 10, 2019

@balloob balloob merged commit a446863 into home-assistant:dev Jul 10, 2019

9 of 11 checks passed

build Workflow: build
Details
ci/circleci: test 3.7 Your tests failed on CircleCI
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@lock lock bot locked and limited conversation to collaborators Jul 11, 2019

@zxdavb zxdavb deleted the zxdavb:bugfix_honeywell_migration branch Jul 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.