Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recording history to Apache Kafka #25085

Merged
merged 9 commits into from Jul 12, 2019

Conversation

@bachya
Copy link
Contributor

commented Jul 11, 2019

Description:

This PR adds support for recording history to an Apache Kafka topic.

Related issue (if applicable): home-assistant/home-assistant.io#9836

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

apache_kafka:
  ip_address: localhost
  port: 9092
  topic: home_assistant_1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

bachya added some commits Jun 23, 2019

Revert "Simplified"
This reverts commit fde4624.
Revert "Revert "Simplified""
This reverts commit 5ae57e6.

@bachya bachya self-assigned this Jul 11, 2019

@bachya bachya referenced this pull request Jul 11, 2019
2 of 2 tasks complete
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

homeassistant/components/apache_kafka/manifest.json Outdated Show resolved Hide resolved

@pvizeli pvizeli merged commit 69cc6af into home-assistant:dev Jul 12, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 78a5dc7...75f316e
Details
codecov/project 94.07% (target 90%)
Details

@bachya bachya deleted the bachya:kafka branch Jul 12, 2019

@lock lock bot locked and limited conversation to collaborators Jul 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.