Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple N26 accounts #25086

Merged
merged 4 commits into from Jul 12, 2019

Conversation

@gorynychzmey
Copy link
Contributor

commented Jul 11, 2019

Breaking Change:

The generation of unique ids for spaces has been changed. Previous format was space_<name>, new format is space_<iban[-4:]_<name>. Otherwise we cannot guarantee uniqueness of ids in case of two accounts have spaces with the same name, e.g. the "main" spaces have always the same name by default. Users may need to remove the stale old id entities, representing spaces, from the entity registry.

Description:

Added support for multiple N26 accounts.

Docs PR:

home-assistant/home-assistant.io#9577

Example entry for configuration.yaml (if applicable):

n26:                                                                                                                                                   
    - username: email1@example.com                                                                                                                    
      password: !secret n26_password1                                                                                                                     
    - username: email2@example.com 
      password: !secret n26_password2    

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@gorynychzmey

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@MartinHjelmare, I've done a lot of mistakes doing rebase for #24345 and decided to make PR from scratch.

Show resolved Hide resolved homeassistant/components/n26/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/n26/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/n26/switch.py Outdated

gorynychzmey added some commits Jul 11, 2019

@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Can be merged when build passes.

@pvizeli pvizeli merged commit eae63cd into home-assistant:dev Jul 12, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 78a5dc7...7b43d5f
Details
codecov/project 94.07% (target 90%)
Details

@lock lock bot locked and limited conversation to collaborators Jul 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.