Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Climate] Hive Add water heater Component post the refresh of the climate component. #25148

Merged
merged 17 commits into from Jul 14, 2019

Conversation

@KJonline
Copy link
Contributor

commented Jul 14, 2019

Description:

Previous to the climate revamp hive used the climate component to show heating and hot water within home assistant. Post the revamp it has been identified that the hot water function should use the water_heater component. This PR is to introduce the water_heater component and tweak the revamped climate component to be in line with the others.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9856

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

Rendili and others added some commits Sep 9, 2017

Merge pull request #3 from home-assistant/master
Rendili home-assistant master merge from home-assistant master
Merge pull request #29 from home-assistant/master
Master - Latest changes
Merge pull request #30 from home-assistant/master
Updated changes 25/05/19
@ghost

This comment has been minimized.

Copy link

commented Jul 14, 2019

Hey there @Rendili, mind taking a look at this pull request as its been labeled with a integration (hive) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@KJonline

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

@balloob - Post the climate revamp, it was mentioned about redoing the hive hot water function as a water_heater component and letting you know about it. This PR is to add the water_heater component to Hive.

@KJonline KJonline referenced this pull request Jul 14, 2019
2 of 2 tasks complete

@KJonline KJonline changed the title Hive Add water heater Component post the refresh of the climate component. [Climate] Hive Add water heater Component post the refresh of the climate component. Jul 14, 2019

@andrewsayre andrewsayre added the climate label Jul 14, 2019

@balloob balloob added this to the 0.96.0 milestone Jul 14, 2019

@pvizeli pvizeli merged commit bcf85a0 into home-assistant:dev Jul 14, 2019

9 checks passed

CI Build #20190714.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pytlint) FullCheck Pytlint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
self.device_type, self.node_id)
self._unique_id = '{}-{}'.format(self.node_id, self.device_type)
self._unit_of_measurement = TEMP_CELSIUS
self.session.entities.append(self)

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jul 15, 2019

Member

Why do we need to append the entity again here? We do it in setup_platform already, right?

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jul 15, 2019

Member

We should probably move the append to async_added_to_hass to avoid calling self.schedule_update_ha_state before the entity has been added to home assistant.

This comment has been minimized.

Copy link
@KJonline

KJonline Jul 15, 2019

Author Contributor

Hi @MartinHjelmare, since this PR has been merged I will remove the duplication in the next release.

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jul 16, 2019

Member

If you can make a PR asap, we can adjust this before 0.96 goes out.

balloob added a commit that referenced this pull request Jul 15, 2019

[Climate] Hive Add water heater Component post the refresh of the cli…
…mate component. (#25148)

* climate_water_heater

* updated names

* Update water_heater

* Update requirements

* Updated reqirements

* Version update

* updated Versiojn

* Update device list

* Removed unused Attributes

@lock lock bot locked and limited conversation to collaborators Jul 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.