Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unit of measurement for ecobee climate #25246

merged 2 commits into from Jul 18, 2019


Copy link

commented Jul 18, 2019


The original ecobee climate component was only using Fahrenheit. This restores the functionality.

Related issue (if applicable): fixes #25215

Pull request with documentation for (if applicable): home-assistant/< PR number goes here>

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cgtobi cgtobi changed the title Fix the unit of measurement Fix the unit of measurement for ecobee climate Jul 18, 2019

@cgtobi cgtobi self-assigned this Jul 18, 2019

@pvizeli pvizeli added this to the 0.96.1 milestone Jul 18, 2019

@pvizeli pvizeli merged commit 89ed26e into home-assistant:dev Jul 18, 2019

9 checks passed

CI Build #20190718.20 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA

@cgtobi cgtobi deleted the cgtobi:climate_ecobee_c2f_fix branch Jul 18, 2019

balloob added a commit that referenced this pull request Jul 18, 2019

Fix the unit of measurement for ecobee climate (#25246)
* Fix the unit of measurement

* Remove unused const
@balloob balloob referenced this pull request Jul 18, 2019

@lock lock bot locked and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
4 participants
You can’t perform that action at this time.