Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore SmartThings A/C on/off services #25259

Merged
merged 3 commits into from Jul 18, 2019

Conversation

@andrewsayre
Copy link
Member

commented Jul 18, 2019

Description:

Add the service turn_on and turn_off implementations back to the SmartThings Air Conditioner climate platform. This was removed as support was initially dropped in Climate 1.0 but added back later.

Related issue (if applicable): fixes #25233

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

andrewsayre added some commits Jul 18, 2019

async def async_update(self):
"""Update the calculated fields of the AC."""
operations = set()
modes = {HVAC_MODE_OFF}

This comment has been minimized.

Copy link
@balloob

balloob Jul 18, 2019

Member

This is fine as it was already like this, but it has the downside that it makes the order of the controls random, and that order is also used in the UI I think (probably shouldn't).

This comment has been minimized.

Copy link
@andrewsayre

andrewsayre Jul 18, 2019

Author Member

It has the effect of showing it alphabetically, I believe. Yes, I the UI should order them as it intends instead of relying on each platform to return a specific sequence. 👍

@balloob balloob merged commit cfc2c58 into dev Jul 18, 2019

11 checks passed

CI Build #20190718.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.06%)
Details
codecov/project 94.06% (target 90%)
Details

@delete-merged-branch delete-merged-branch bot deleted the smartthings_restore_on_off branch Jul 18, 2019

balloob added a commit that referenced this pull request Jul 18, 2019

Restore SmartThings A/C on/off services (#25259)
* Restore ST A/C on/off services

* Use correct OFF const

* Support AC HVAC_MODE_OFF
@balloob balloob referenced this pull request Jul 18, 2019

@lock lock bot locked and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.