Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak evohome migration #25281

Merged
merged 12 commits into from Jul 22, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Jul 18, 2019

Breaking Change:

None

Description:

  • refactor setpoints: reduce unnecessary I/O and always use up-to-date schedule
  • address potential bug if a device has a null schedule
  • improve docstrings, self-documenting code, etc.
  • de-linting (and remove unneeded code) / adding type hints

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): unchanged

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned zxdavb Jul 18, 2019

@zxdavb zxdavb marked this pull request as ready for review Jul 18, 2019

zxdavb added some commits Jul 15, 2019

Initial commit
add hvac_action to zones, remove target_temp from controller

fix incorrect hvac_action

de-lint

Initial commit

de-lint & minor refactor

tweak docstrings, and type hints

tweak docstrings

@zxdavb zxdavb changed the title Tweak evohome Tweak evohome migration Jul 21, 2019

@pvizeli pvizeli added this to the 0.96.4 milestone Jul 22, 2019

@pvizeli pvizeli merged commit bf37cc8 into home-assistant:dev Jul 22, 2019

9 checks passed

CI Build #20190721.64 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@zxdavb zxdavb deleted the zxdavb:tweak_evohome branch Jul 22, 2019

@lock lock bot locked and limited conversation to collaborators Jul 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.