Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python-wink method names #25285

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@w1ll1am23
Copy link
Collaborator

commented Jul 19, 2019

Description:

Looks like during the climate update some of the python-wink method names were renamed on accident. This fixes the calls.

Related issue (if applicable): fixes #25232

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@pvizeli pvizeli modified the milestones: 0.96.1, 0.96.2 Jul 19, 2019

@pvizeli pvizeli merged commit bc7e1a3 into home-assistant:dev Jul 19, 2019

9 checks passed

CI Build #20190719.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
@djtommye

This comment has been minimized.

Copy link

commented Jul 19, 2019

Is there a way to merge these fixes into my current configuration? (Sorry - not a developer)

@w1ll1am23

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2019

@djtommye take a look at my last comment here #25306

balloob added a commit that referenced this pull request Jul 19, 2019

Fixed python-wink method names (#25285)
* Fixed python-wink method names

* Fixed aux heat
@balloob balloob referenced this pull request Jul 19, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Release has been tagged, should be out in hour or 2 on all platforms

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into hive-splitfiles-testing

* 'dev' of https://github.com/home-assistant/home-assistant: (109 commits)
  Multiroom support for snapcast (home-assistant#24061)
  Turn on device before setting mode (home-assistant#25314)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Updated frontend to 20190719.0
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Fixed python-wink method names (home-assistant#25285)
  Add services to set and remove Simplisafe PINs (home-assistant#25207)
  Add MQTT climate precision (home-assistant#25265)
  Add support for Rainforest Eagle-200 (home-assistant#24919)
  Update azure-pipelines-ci.yml for Azure Pipelines
  ...

# Conflicts:
#	homeassistant/components/hive/climate.py

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (112 commits)
  Avoid creating temporary lists (home-assistant#25317)
  Multiroom support for snapcast (home-assistant#24061)
  Turn on device before setting mode (home-assistant#25314)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Updated frontend to 20190719.0
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Fixed python-wink method names (home-assistant#25285)
  Add services to set and remove Simplisafe PINs (home-assistant#25207)
  Add MQTT climate precision (home-assistant#25265)
  Add support for Rainforest Eagle-200 (home-assistant#24919)
  ...

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'master' of https://github.com/home-assistant/home-assis…
…tant

* 'master' of https://github.com/home-assistant/home-assistant: (888 commits)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Update azure-pipelines-ci.yml for Azure Pipelines
  Bumped version to 0.96.1
  Added states and modes for zwave climate (home-assistant#25274)
  Add hvac modes back to opentherm (home-assistant#25268)
  Restore SmartThings A/C on/off services (home-assistant#25259)
  Update CT80 Humidity call (home-assistant#25258)
  ecobee Preset Fix (home-assistant#25256)
  Fix the unit of measurement for ecobee climate (home-assistant#25246)
  Make presets prettier (home-assistant#25245)
  Fix eq3btsmart (home-assistant#25238)
  Show off value (home-assistant#25236)
  Updated frontend to 20190718.0
  ...

@lock lock bot locked and limited conversation to collaborators Jul 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.