Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[climate] Correct honeywell supported_features #25292

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Jul 19, 2019

Breaking Change:

None

Description:

Currently, the honeywell UI show three temperature spinners (instead of only upper, lower bound) because

    self._supported_features = (SUPPORT_PRESET_MODE |
                                SUPPORT_TARGET_TEMPERATURE |
                                SUPPORT_TARGET_TEMPERATURE_RANGE)

This PR removed SUPPORT_TARGET_TEMPERATURE.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@zxdavb zxdavb changed the title [climate] Correct honeywell supported features [climate] Correct honeywell supported_features Jul 19, 2019

@ghost ghost assigned zxdavb Jul 19, 2019

@zxdavb zxdavb marked this pull request as ready for review Jul 19, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Guess you would have some feedback on this home-assistant/architecture#264 😆

@pvizeli pvizeli added this to the 0.96.2 milestone Jul 19, 2019

@pvizeli pvizeli merged commit 5015311 into home-assistant:dev Jul 19, 2019

9 checks passed

CI Build #20190719.15 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
@elupus

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Just return none from temperature property instead. That supported flag is going away.

@elupus

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Or more precise, return none when in heat_cool mode and value when in heat or cool. Opposite for the range values.

https://github.com/elupus/hass_nibe/blob/2334787b1af0a033f186e5f75231099b996d6d55/climate.py#L302

@zxdavb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

I note this PR has already been merged, but now I'm having second thoughts...

I find @elupus's proposed solution acceptable. I just need telling what is the official solution.

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

I think that we should drop RANGE and return None from temperatures you don't offer.

balloob added a commit that referenced this pull request Jul 19, 2019

@balloob balloob referenced this pull request Jul 19, 2019

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into hive-splitfiles-testing

* 'dev' of https://github.com/home-assistant/home-assistant: (109 commits)
  Multiroom support for snapcast (home-assistant#24061)
  Turn on device before setting mode (home-assistant#25314)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Updated frontend to 20190719.0
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Fixed python-wink method names (home-assistant#25285)
  Add services to set and remove Simplisafe PINs (home-assistant#25207)
  Add MQTT climate precision (home-assistant#25265)
  Add support for Rainforest Eagle-200 (home-assistant#24919)
  Update azure-pipelines-ci.yml for Azure Pipelines
  ...

# Conflicts:
#	homeassistant/components/hive/climate.py

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (112 commits)
  Avoid creating temporary lists (home-assistant#25317)
  Multiroom support for snapcast (home-assistant#24061)
  Turn on device before setting mode (home-assistant#25314)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Updated frontend to 20190719.0
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Fixed python-wink method names (home-assistant#25285)
  Add services to set and remove Simplisafe PINs (home-assistant#25207)
  Add MQTT climate precision (home-assistant#25265)
  Add support for Rainforest Eagle-200 (home-assistant#24919)
  ...

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'master' of https://github.com/home-assistant/home-assis…
…tant

* 'master' of https://github.com/home-assistant/home-assistant: (888 commits)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Update azure-pipelines-ci.yml for Azure Pipelines
  Bumped version to 0.96.1
  Added states and modes for zwave climate (home-assistant#25274)
  Add hvac modes back to opentherm (home-assistant#25268)
  Restore SmartThings A/C on/off services (home-assistant#25259)
  Update CT80 Humidity call (home-assistant#25258)
  ecobee Preset Fix (home-assistant#25256)
  Fix the unit of measurement for ecobee climate (home-assistant#25246)
  Make presets prettier (home-assistant#25245)
  Fix eq3btsmart (home-assistant#25238)
  Show off value (home-assistant#25236)
  Updated frontend to 20190718.0
  ...

@lock lock bot locked and limited conversation to collaborators Jul 20, 2019

@zxdavb zxdavb deleted the zxdavb:bugfix_honeywell_migration branch Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.