Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Maps Location Tracker to use locationsharinglib==4.0.2 #25316

Merged
merged 3 commits into from Jul 20, 2019

Conversation

@shbatm
Copy link
Contributor

commented Jul 19, 2019

Breaking Change:

Google Passwords are no longer required to be provided in your config. An external program is now required to obtain the necessary cookie file to place in your Home Assistant config directory. This is due to the authentication process being removed from the underlying package. Existing users should remove the password: entry from their config file (username is still required). The cookie file previously generated should still be valid and will allow the tracker to continue functioning normally until the cookie is invalidated. New users will need to follow the instructions on the Google Maps Location Sharing page to create their cookie file.

Description:

Update the Google Maps location tracker component to use the most recent version of the underlying package (v4.0.2).

I am adding this PR on behalf of @costastf and per this forum post: https://community.home-assistant.io/t/google-maps-device-tracking-setup/59944/65

Related issue (if applicable):
fixes #23349, fixes #25312, fixes #24490, fixes #24025

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9918

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • [n/a] Tests have been added to verify that the new code works.
@dshokouhi

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

are existing users required to update their current cookie? or is the new cookie process only for new users? the code seems to look for the same cookie name as previously.

@shbatm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

@dshokouhi I believe the same cookie will work if it works currently. From my understanding via @costasrf, the new version of locationsharinglib removes the authentication mechanism and expects a valid cookie file to be provided, rather than trying to generate one itself.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Please add to the breaking change paragraph what the user needs to do to cope with the breaking change.

@shbatm

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

@MartinHjelmare: Done.

@MartinHjelmare MartinHjelmare merged commit 83581be into home-assistant:dev Jul 20, 2019

9 checks passed

CI Build #20190720.34 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@lock lock bot locked and limited conversation to collaborators Jul 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.