Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zwave climate mappings for Pending Heat/Cool #25327

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@eyager1
Copy link
Contributor

commented Jul 20, 2019

Description:

Reference #25274

When a zwave thermostat is showing the operating status of "Pending Heat" and "Pending Cool" it means that it is waiting on a minimum off period timer to expire that was initiated at the end of a cycle before it is will allow another heating or cooling cycle to begin to prevent short cycling the HVAC equipment. My thermostat shows "Wait" on its LCD display when this is happening. The HVAC equipment should be going to an idle status when the thermostat is reporting that status. Thus hvac_action attribute should be idle when thermostat is in Pending Heat or Pending Cool.

For those of us who will monitor hvac_action attribute to calculate energy usage of the won't have an accurate accounting without this patch applied because the time delay added on the end of every cycle will be counted as operating time and this time can be very considerable.

Checklist:

  • [ x] The code change is tested and works locally.
  • [ x] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the [development checklist][dev-checklist]
Update zwave climate mappings
hvac_action should be idle when thermostat is in Pending Heat or Pending Cool.

@eyager1 eyager1 requested a review from home-assistant/z-wave as a code owner Jul 20, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 20, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@frenck frenck added the climate label Jul 20, 2019

@balloob balloob added this to the 0.96.3 milestone Jul 21, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Thanks!

@balloob balloob merged commit 5e29d4d into home-assistant:dev Jul 21, 2019

9 checks passed

CI Build #20190720.2 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

balloob added a commit that referenced this pull request Jul 21, 2019

Update zwave climate mappings (#25327)
hvac_action should be idle when thermostat is in Pending Heat or Pending Cool.
@balloob balloob referenced this pull request Jul 21, 2019

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.