Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Daikin A/C on/off services #25332

Merged
merged 1 commit into from Jul 20, 2019

Conversation

@fredrike
Copy link
Contributor

commented Jul 20, 2019

Description:

Add the service turn_on and turn_off implementations back to the Daikin Air Conditioner climate platform. This was removed as support was initially dropped in Climate 1.0 but added back later.

Related issue (if applicable): fixes #18578

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@ghost

This comment has been minimized.

Copy link

commented Jul 20, 2019

Hey there @rofrantz, mind taking a look at this pull request as its been labeled with a integration (daikin) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@MartinHjelmare MartinHjelmare merged commit 0da0dda into home-assistant:dev Jul 20, 2019

9 checks passed

CI Build #20190720.7 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
@fredrike

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Thnx @MartinHjelmare!

Could this be part of next subrelease?

@frenck frenck added the climate label Jul 20, 2019

@frenck frenck added this to the 0.96.3 milestone Jul 20, 2019

@frenck

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Added 0.96.3 milestone.

@lock lock bot locked and limited conversation to collaborators Jul 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.