Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hvac_modes list being null #25347

Merged
merged 2 commits into from Jul 21, 2019

Conversation

@schmic
Copy link
Contributor

commented Jul 20, 2019

Breaking Change:

None.

Description:

I tried to solve the issue the way it's solved in the hvac_mode()-function, that's why the if-case is stated like that.

Related issue (if applicable): fixes #25345

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@schmic schmic requested a review from home-assistant/z-wave as a code owner Jul 20, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 20, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@schmic

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Also fixes #25290

@schmic schmic changed the title Fix for empty hvac_modes list Fix for hvac_modes list being null Jul 20, 2019

@balloob balloob merged commit ba04ff1 into home-assistant:dev Jul 21, 2019

9 checks passed

CI Build #20190720.40 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@balloob balloob added this to the 0.96.3 milestone Jul 21, 2019

balloob added a commit that referenced this pull request Jul 21, 2019

Fix for hvac_modes list being null (#25347)
* Fix for empty hvac_modes list

* Empty list instead of default value for hvac_modes

@balloob balloob referenced this pull request Jul 21, 2019

Merged

0.96.3 #25376

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.