Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available attribute to ZHA device info that is accessible via API #25349

Merged

Conversation

@dmulcahey
Copy link
Contributor

commented Jul 20, 2019

Description:

This PR adds device availability to the info returned by the API for ZHA devices.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@dmulcahey dmulcahey added this to the 0.96.3 milestone Jul 20, 2019

@dmulcahey dmulcahey requested a review from Adminiuga Jul 20, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Where will this have an effect? Does this show anywhere?

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Where will this have an effect? Does this show anywhere?

Initially here: https://github.com/dmulcahey/zha-network-card

This is to help with the removal of ZHA entities. Many people were using them to monitor for when devices fell off the network.

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Keep in mind, this info is on ZHA’s device object and is for the ZHA web socket API. Just in case that wasn’t clear...

@dmulcahey dmulcahey merged commit 7ea27c0 into home-assistant:dev Jul 20, 2019

9 checks passed

CI Build #20190720.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

balloob added a commit that referenced this pull request Jul 21, 2019

@balloob balloob referenced this pull request Jul 21, 2019

@lock lock bot locked and limited conversation to collaborators Jul 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.