Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary patch to fix KNX climate devices #25356

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@farmio
Copy link
Contributor

commented Jul 20, 2019

Description:

This is a temporary patch for knx climate devices. It should be reverted when #24738 is merged to release.

Related issue (if applicable): It should fix #25247 for 0.96

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
temporary patch to fix KNX climate devices
This is a temporary patch for knx climate devices. It should be reverted when #24738 is merged to release. 
It should fix #25247 for 0.96
@ghost

This comment has been minimized.

Copy link

commented Jul 20, 2019

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration (knx) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Thanks !

@balloob balloob merged commit 0143026 into home-assistant:rc Jul 21, 2019

9 checks passed

CI Build #20190720.43 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
@fernasneri

This comment has been minimized.

Copy link

commented on 09f2657 Jul 21, 2019

I am a complete newbie to home assitant configuration, were I can locate the "climate.py" file?

This comment has been minimized.

Copy link
Owner Author

replied Jul 22, 2019

@fernasneri Hi! You should not do this - an update would revert changes. This is a patch that is shipped with home-assistant 0.96.3 so now you can just update your HA instance and your set.
Please be sure to ask questions in an issue; here is code review of a commit - this is rather unlikely to be seen.

@balloob balloob referenced this pull request Jul 21, 2019

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019

@farmio farmio deleted the farmio:patch-1 branch Jul 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.