Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve geniushub logging and bump client #25359

Merged
merged 5 commits into from Jul 21, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Jul 20, 2019

Breaking Change:

None

Description:

Adds DEBUG logging to geniushub. Without this, it will be difficult to address issues such as #25343 (note that this is not a fix for that issue)

Related issue (if applicable): see above

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

logger:
  logs:
    geniushubclient: debug
    homeassistant.components.geniushub: debug
    homeassistant.components.geniushub.climate: debug

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned zxdavb Jul 20, 2019

@zxdavb zxdavb changed the title Improve geniushub logging and bump client [climate] Improve geniushub logging and bump client Jul 21, 2019

@zxdavb zxdavb marked this pull request as ready for review Jul 21, 2019

@balloob balloob modified the milestone: 0.96.3 Jul 21, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Looks like you included some Python 3.6 only code in geniushub-client

homeassistant/components/geniushub/init.py:7:0: E0001: Cannot import 'geniushubclient' due to syntax error 'Variable annotation syntax is only supported in Python 3.6 and greater (, line 568)' (syntax-error)

We can merge this for the next release, won't be able to include it as hotfix, as 96 still supports 3.5

@fabaff fabaff changed the title [climate] Improve geniushub logging and bump client Improve geniushub logging and bump client Jul 21, 2019

@zxdavb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

OK, remove the type hints - 3.5-compatible now.

zxdavb added some commits Jul 20, 2019

@balloob balloob added this to the 0.96.3 milestone Jul 21, 2019

@balloob balloob merged commit 97a13bd into home-assistant:dev Jul 21, 2019

9 checks passed

CI Build #20190721.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
@balloob

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Thanks, will be released shortly 👍

balloob added a commit that referenced this pull request Jul 21, 2019

Improve geniushub logging and bump client (#25359)
* add debug logging

* bump geniushub client library

* delint

* bump again

* bump again, again
@balloob balloob referenced this pull request Jul 21, 2019

@zxdavb zxdavb deleted the zxdavb:bugfix_geniushub branch Jul 21, 2019

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.