Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[climate] Bugfix/Tweak honeywell migration #25369
This has been removed - there is no breaking change now.
FWIW, I think the demand response data should have been there in the first place, and is not an enhancement. It adds these lines of code to
if self._device._data['drData']: data['dr_phase'] = self._device._data['drData'].get('Phase')
Related issue (if applicable): fixes #25412
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for
I try to remove/reduce these lint hints where possible, such as switching from
Unfortunately, the client library is not mine, and has had no changes for >2 years. The owner is around, though...
But in fact, honeywell is nothing to do with me, really, I only got involved because someone stuck Honeywell US and Honeywell International (which uses the evohome client library) together in the same integration & I wanted to pull the international bit out. I don't even have regular access to any Honeywell systems...
Sorry, I have no appetite/time for fixing this client library.
Is it OK to accept this PR as is, given that it is much better than it was?