Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZHA entity remove and re-add scenario #25370

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@dmulcahey
Copy link
Contributor

commented Jul 21, 2019

Description:

This PR corrects the handling of the remove future and the unsub methods when an entity is removed from the system and subsequently re-added. For example this is done in the handling of entity registry events when an entity id has been changed by a user.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@dmulcahey dmulcahey added this to the 0.96.3 milestone Jul 21, 2019

@dmulcahey dmulcahey requested a review from Adminiuga Jul 21, 2019

@ghost ghost assigned Adminiuga and dmulcahey Jul 21, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 21, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit 7a8130c into home-assistant:dev Jul 21, 2019

9 checks passed

CI Build #20190721.31 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

balloob added a commit that referenced this pull request Jul 21, 2019

@balloob balloob referenced this pull request Jul 21, 2019

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.