Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Daikin preset modes #25395

Merged
merged 2 commits into from Jul 24, 2019

Conversation

@fredrike
Copy link
Contributor

commented Jul 22, 2019

Description:

Daikin preset modes does not have a Home option.

Also cleaned up some codes as the pydaikin 1.5.x have a set_holiday method.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

fredrike added some commits Jul 22, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 22, 2019

Hey there @rofrantz, mind taking a look at this pull request as its been labeled with a integration (daikin) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@fredrike fredrike referenced this pull request Jul 23, 2019
8 of 9 tasks complete

@MartinHjelmare MartinHjelmare added this to Needs review in Dev Jul 23, 2019

Dev automation moved this from Needs review to Reviewer approved Jul 24, 2019

@balloob balloob added this to the 0.96.4 milestone Jul 24, 2019

@balloob balloob merged commit 828f76c into home-assistant:dev Jul 24, 2019

9 checks passed

CI Build #20190722.22 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Jul 24, 2019

balloob added a commit that referenced this pull request Jul 24, 2019

Update Daikin preset modes (#25395)
* fix preset documentation

* Use pydaikin set holiday method
@balloob balloob referenced this pull request Jul 24, 2019
@fredrike fredrike referenced this pull request Jul 24, 2019
2 of 2 tasks complete

@lock lock bot locked and limited conversation to collaborators Jul 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.