Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[climate] Correct evohome hvac_action #25407

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Jul 22, 2019

Breaking Change:

None known

Description:

Fixes a stupid typo that results in hvac_action having the wrong value.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@zxdavb zxdavb changed the title Correct evohome hvac_action [climate] Correct evohome hvac_action Jul 22, 2019

@zxdavb zxdavb marked this pull request as ready for review Jul 22, 2019

@cgtobi

cgtobi approved these changes Jul 23, 2019

Copy link
Collaborator

left a comment

LGTM

@cgtobi cgtobi added this to the 0.96.4 milestone Jul 23, 2019

@cgtobi cgtobi merged commit 7cf0684 into home-assistant:dev Jul 23, 2019

9 checks passed

CI Build #20190722.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@zxdavb zxdavb deleted the zxdavb:bugfix_evohome branch Jul 23, 2019

balloob added a commit that referenced this pull request Jul 24, 2019

[climate] Correct evohome hvac_action (#25407)
* inital commit

* take account of rounding up of curr_temp
@balloob balloob referenced this pull request Jul 24, 2019

@lock lock bot locked and limited conversation to collaborators Jul 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.