Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cors for static files #25468

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@balloob
Copy link
Member

commented Jul 24, 2019

Description:

Make sure that the CORS setting for the HTTP integration also applies to static folders.

Example entry for configuration.yaml (if applicable):

http:
  cors_allowed_origins:
    - https://www.home-assistant.io

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Jul 24, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 24, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (http) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob added this to the 0.96.5 milestone Jul 24, 2019

@MartinHjelmare MartinHjelmare added this to Needs review in Dev Jul 25, 2019

Dev automation moved this from Needs review to Reviewer approved Jul 25, 2019

@pvizeli pvizeli merged commit fae3546 into dev Jul 25, 2019

11 checks passed

CI Build #20190724.45 had test failures
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.03%)
Details
codecov/project 94.03% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Jul 25, 2019

@delete-merged-branch delete-merged-branch bot deleted the cors-static branch Jul 25, 2019

balloob added a commit that referenced this pull request Jul 25, 2019

@balloob balloob referenced this pull request Jul 25, 2019

@lock lock bot locked and limited conversation to collaborators Jul 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.