Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nest turning off eco #25472

Merged
merged 2 commits into from Jul 25, 2019

Conversation

@balloob
Copy link
Member

commented Jul 25, 2019

Description:

If Nest would support both heat and cool, turning eco mode off would result in us trying to write auto to the Nest API while it expected heat_cool. This cleans up the mapping.

Also adds HVAC action.

Related issue (if applicable): #25427

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

balloob added some commits Jul 25, 2019

@balloob balloob added this to the 0.96.5 milestone Jul 25, 2019

@balloob balloob requested a review from awarecan as a code owner Jul 25, 2019

@ghost ghost assigned awarecan Jul 25, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 25, 2019

Hey there @awarecan, mind taking a look at this pull request as its been labeled with a integration (nest) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit a50f1ae into dev Jul 25, 2019

9 checks passed

CI Build #20190725.1 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

@delete-merged-branch delete-merged-branch bot deleted the fix-nest-turn-off-eco branch Jul 25, 2019

balloob added a commit that referenced this pull request Jul 25, 2019

Fix Nest turning off eco (#25472)
* Fix Nest turning off eco

* Add hvac action
@balloob balloob referenced this pull request Jul 25, 2019

@lock lock bot locked and limited conversation to collaborators Jul 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.