Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arcus trigonometry functions to templates #25510

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@tomilehto
Copy link
Contributor

commented Jul 27, 2019

Description:

This PR adds arcus trigonometry functions asin, acos, atan and atan2 to template functions.

Atan function is required for example to calculate wet bulb temperature, which more closely describes how temperature feels, from (dry bulb) temperature and relative humidity.

For more info about wet bulb temperature:
https://en.wikipedia.org/wiki/Wet-bulb_temperature
https://journals.ametsoc.org/doi/full/10.1175/JAMC-D-11-0143.1

Related issue (if applicable):

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9982

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@tomilehto tomilehto requested a review from home-assistant/core as a code owner Jul 27, 2019

@project-bot project-bot bot added this to Needs review in Dev Jul 27, 2019

@tomilehto tomilehto force-pushed the tomilehto:arc-trigonometry branch from 271b80e to ab1b41e Jul 27, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2019

Hi @tomilehto,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@tomilehto tomilehto force-pushed the tomilehto:arc-trigonometry branch from ab1b41e to 3529249 Aug 2, 2019

@tomilehto

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

Rebased and run black

Dev automation moved this from Needs review to Reviewer approved Aug 9, 2019

@balloob
balloob approved these changes Aug 9, 2019

@balloob balloob merged commit 5b516fc into home-assistant:dev Aug 9, 2019

11 checks passed

CI Build #20190802.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.01%)
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 9, 2019

@tomilehto tomilehto deleted the tomilehto:arc-trigonometry branch Aug 9, 2019

@lock lock bot locked and limited conversation to collaborators Aug 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.