Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zwave Climate: Fan state attribute missing (#25287) #25573

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@jaminh
Copy link
Contributor

commented Jul 30, 2019

Related issue (if applicable): fixes #25287

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@jaminh jaminh requested a review from home-assistant/z-wave as a code owner Jul 30, 2019

@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Hi @jaminh,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost

This comment has been minimized.

Copy link

commented Jul 30, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@homeassistant homeassistant added cla-signed and removed cla-needed labels Jul 30, 2019

@Adminiuga
Copy link
Contributor

left a comment

Looks good

Dev automation moved this from Needs review to Reviewer approved Jul 30, 2019

@pvizeli

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

That fix nothing because there is no code that read this property.

Dev automation moved this from Reviewer approved to Review in progress Jul 30, 2019

@pvizeli
Copy link
Member

left a comment

Please provide screenshots with before/after

@jaminh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Fan state is back with latest changes.
Screenshot from 2019-07-30 08-34-33

@pvizeli pvizeli added this to the 0.97.0 milestone Aug 2, 2019

"""Return the optional state attributes."""
data = super().device_state_attributes
if self.fan_state:
data[ATTR_FAN_STATE] = self.fan_state

This comment has been minimized.

Copy link
@pvizeli

pvizeli Aug 2, 2019

Member

call this fan_action, could be that we add this later like the hvac_actions

This comment has been minimized.

Copy link
@jaminh

jaminh Aug 5, 2019

Author Contributor

I changed all references from fan "state" to "action" and I was able to see the new attribute in my install so I think everything should be working. I can squash all the commits down to one unless there are more changes?

@pvizeli pvizeli removed this from the 0.97.0 milestone Aug 2, 2019

@jaminh jaminh force-pushed the jaminh:fix-zwave-fan-state-25287 branch from 8170426 to 8468282 Aug 4, 2019

Zwave Climate: Fan state attribute missing (#25287)
Add fan state back in to device state attributes
Change fan state to fan action

@jaminh jaminh force-pushed the jaminh:fix-zwave-fan-state-25287 branch from aff440e to 34e4245 Aug 5, 2019

@pvizeli
pvizeli approved these changes Aug 5, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 5, 2019

@pvizeli pvizeli merged commit 5e00b54 into home-assistant:dev Aug 5, 2019

11 checks passed

CI Build #20190805.2 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.02%)
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 5, 2019

@lock lock bot locked and limited conversation to collaborators Aug 6, 2019

@jaminh jaminh deleted the jaminh:fix-zwave-fan-state-25287 branch Aug 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.