Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python support to min Python 3.6.0 #25582

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@balloob
Copy link
Member

commented Jul 30, 2019

Breaking Change:

Python 3.6.0 is now the minimum supported version.

Description:

Bump minimum supported version to Python 3.6.0 and update some type annotations to enforce it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Jul 30, 2019

@project-bot project-bot bot added this to Needs review in Dev Jul 30, 2019

Dev automation moved this from Needs review to Reviewer approved Jul 30, 2019

@andrewsayre
Copy link
Member

left a comment

Wohoo!

@balloob balloob merged commit 39b8102 into dev Jul 30, 2019

10 checks passed

CI Build #20190730.48 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f8bb0e1...b3ec137
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Jul 30, 2019

@delete-merged-branch delete-merged-branch bot deleted the disable-py35 branch Jul 30, 2019

@lock lock bot locked and limited conversation to collaborators Jul 31, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.