Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ZHA Zigbee Cluster report configuration #25589

Merged
merged 7 commits into from Aug 4, 2019

Conversation

@Adminiuga
Copy link
Contributor

commented Jul 31, 2019

Description:

Refactor ZHA channel ZCL attribute reporting configuration.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@project-bot project-bot bot added this to Needs review in Dev Jul 31, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 31, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@ghost ghost assigned Adminiuga and dmulcahey Jul 31, 2019

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-zcl-reporting branch from 1be78ea to dc6ed8e Jul 31, 2019

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Jul 31, 2019

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-zcl-reporting branch 2 times, most recently from ff6ee3e to 304165f Aug 3, 2019

Adminiuga added 5 commits Jul 30, 2019
Remove INPUT_BIND_ONLY_CLUSTER ZHA core registry.
We always need bind a cluster, but not always need to configure
attribute reporting. No reporting is done on ZCL "client" clusters.

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-zcl-reporting branch from 304165f to 4813fc8 Aug 4, 2019

@Adminiuga Adminiuga force-pushed the Adminiuga:ac/zha-zcl-reporting branch from 170aced to 40b98a0 Aug 4, 2019

@Adminiuga Adminiuga changed the title WIP Refactor ZHA Zigbee Cluster report configuration Refactor ZHA Zigbee Cluster report configuration Aug 4, 2019

Dev automation moved this from Incoming to Reviewer approved Aug 4, 2019

@Adminiuga Adminiuga marked this pull request as ready for review Aug 4, 2019

@dmulcahey dmulcahey merged commit f7cfe90 into home-assistant:dev Aug 4, 2019

11 checks passed

CI Build #20190804.47 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 0d95ad3...112a7dd
Details
codecov/project 94.01% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 4, 2019

@Adminiuga Adminiuga deleted the Adminiuga:ac/zha-zcl-reporting branch Aug 4, 2019

@Adminiuga Adminiuga referenced this pull request Aug 5, 2019
7 of 7 tasks complete

@lock lock bot locked and limited conversation to collaborators Aug 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.