Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HomeKit CO2 sensors #25603

Merged
merged 45 commits into from Aug 1, 2019

Conversation

@tleegaard
Copy link
Contributor

commented Jul 31, 2019

Breaking Change:

Description:

Support for HomeKit CO2 sensors.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
tleegaard added 13 commits Jul 31, 2019
Remove duplicate logic
The current one duplicates logic and it got flagged up in review last time someone added a binary sensor. /Jc2k
@ghost

This comment has been minimized.

Copy link

commented Jul 31, 2019

Hey there @Jc2k, mind taking a look at this pull request as its been labeled with a integration (homekit_controller) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@project-bot project-bot bot added this to Needs review in Dev Jul 31, 2019

@Jc2k Jc2k changed the title Add support for CO2 sensor Add support for HomeKit CO2 sensors Jul 31, 2019

tleegaard added 4 commits Jul 31, 2019

@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Jul 31, 2019

@tleegaard

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@Jc2k - I'm not sure how to solve this. Can you help me out?
E AssertionError: Cannot map test homekit services to homeassistant domain

tleegaard added 3 commits Aug 1, 2019

Dev automation moved this from Review in progress to Reviewer approved Aug 1, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

I think we can merge when the formatting is fixed.

tleegaard added 2 commits Aug 1, 2019
@tleegaard

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@MartinHjelmare is it possible to get more info from the failed check? I don't know how to resolve this:

========================== Starting Command Output ===========================
in/bash --noprofile --norc /__w/_temp/0199d6f3-d130-41e9-93e9-863134f8dd31.sh
##[error]Bash exited with code '1'.
Finishing: Check Black formatting
tleegaard added 4 commits Aug 1, 2019
tleegaard added 2 commits Aug 1, 2019

@Jc2k Jc2k self-requested a review Aug 1, 2019

@Jc2k
Jc2k approved these changes Aug 1, 2019
Copy link
Contributor

left a comment

Think we got there. Latest commit passes all my checks locally, including all linters, formatters and tests 🎉

@tleegaard

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

Hooray 🎉 That took quite a few commits - but hopefully it will be easier for me next time! Thank you for all the help!

@Jc2k Jc2k merged commit 61c6838 into home-assistant:dev Aug 1, 2019

11 checks passed

CI Build #20190801.42 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 96.96% of diff hit (target 93.99%)
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 1, 2019

@Jc2k

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

No problem! Thank you for your efforts getting it over the line :)

@tleegaard tleegaard referenced this pull request Aug 2, 2019
2 of 2 tasks complete

@lock lock bot locked and limited conversation to collaborators Aug 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.