Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add each fronius sensor as own template #25608

Merged
merged 9 commits into from Aug 1, 2019

Conversation

@nielstron
Copy link
Contributor

commented Jul 31, 2019

Breaking Change:

Description:

This update adds the often used templates to the state engine per default and hides the overall components. The reason is that there is almost no use case without the templates and they are tricky yet repetitive to define.

Related issue (if applicable): as an example issue 11 on the libraries page

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10028

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@project-bot project-bot bot added this to Needs review in Dev Jul 31, 2019

@ghost ghost assigned nielstron Jul 31, 2019

@nielstron nielstron referenced this pull request Jul 31, 2019
2 of 2 tasks complete

@nielstron nielstron force-pushed the nielstron:pyfronius branch 2 times, most recently from d5fc7f5 to ed6a9e6 Jul 31, 2019

@MartinHjelmare
Copy link
Member

left a comment

If we need a manager of entities that manager shouldn't be an entity itself.

homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved

Dev automation moved this from Needs review to Review in progress Jul 31, 2019

@MartinHjelmare MartinHjelmare changed the title Add each sensor as own template Add each fronius sensor as own template Jul 31, 2019

@nielstron nielstron force-pushed the nielstron:pyfronius branch from 80a8b89 to 8584a0d Jul 31, 2019

Small fixes
Rename fetching adapters to adapters
throw away non-working system overviews
slightly change naming
remove scan_interval from schema
formatting
@MartinHjelmare
Copy link
Member

left a comment

Looks good! Can be merged when last comment is addressed and build passes.

homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved

Dev automation moved this from Review in progress to Reviewer approved Aug 1, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Please rebase to solve the merge conflict.

@nielstron nielstron referenced this pull request Aug 1, 2019
2 of 2 tasks complete

@nielstron nielstron force-pushed the nielstron:pyfronius branch 2 times, most recently from e87d940 to 849428d Aug 1, 2019

@nielstron nielstron force-pushed the nielstron:pyfronius branch from 849428d to 7c8bfce Aug 1, 2019

@nielstron nielstron force-pushed the nielstron:pyfronius branch from 1bea3ff to 6d102ab Aug 1, 2019

@nielstron nielstron force-pushed the nielstron:pyfronius branch from 6d102ab to 53b9d62 Aug 1, 2019

@MartinHjelmare MartinHjelmare merged commit 87bc213 into home-assistant:dev Aug 1, 2019

11 checks passed

CI Build #20190801.97 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c2556d9...53b9d62
Details
codecov/project 94% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 1, 2019

@lock lock bot locked and limited conversation to collaborators Aug 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.