Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ring switch platform #25612

Merged
merged 12 commits into from Aug 6, 2019

Conversation

@rossdargan
Copy link
Contributor

commented Jul 31, 2019

Description:

Adds the ability to add switches to control ring sirens (for Floodlights and indoor cams)

Note I'm using the old style of testing so I can get this into this version (this is the same style used by the other ring tests to keep them consistent). A later P/R will update the tests

Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#10062

Example entry for configuration.yaml (if applicable):

switch:
  - platform: ring

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
tests/components/ring/test_switch.py Outdated Show resolved Hide resolved
homeassistant/components/ring/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ring/switch.py Show resolved Hide resolved
homeassistant/components/ring/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ring/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ring/switch.py Show resolved Hide resolved

Dev automation moved this from Needs review to Review in progress Jul 31, 2019

@MartinHjelmare MartinHjelmare changed the title Add in a switch platform to ring. Add ring switch platform Jul 31, 2019

rossdargan added 6 commits Jul 31, 2019
tests/fixtures/manifest.json Outdated Show resolved Hide resolved
tests/components/ring/conftest.py Outdated Show resolved Hide resolved
tests/components/ring/conftest.py Outdated Show resolved Hide resolved
rossdargan added 2 commits Aug 3, 2019
@rossdargan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

@MartinHjelmare Updated following your great feedback :)

@MartinHjelmare
Copy link
Member

left a comment

There's a .ring_cache.pickle file saved. We shouldn't save that. We may need to patch something to avoid that?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

If the cache file was generated during the test run, that's a sign that I/O is done during the tests. We shouldn't do any I/O in the tests. We have to patch all library calls that do I/O.

tests/components/ring/test_switch.py Outdated Show resolved Hide resolved
tests/components/ring/test_switch.py Outdated Show resolved Hide resolved
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

Dev automation moved this from Review in progress to Reviewer approved Aug 5, 2019

@rossdargan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@MartinHjelmare I'm not sure if this is what you wanted, but figured this was the easiest way to find out!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

I think we can merge when build passes and a docs PR is linked in the PR description. We should update docs since the switch platform is new, right?

@rossdargan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

I think we can merge when build passes and a docs PR is linked in the PR description. We should update docs since the switch platform is new, right?

Yes, it needs updating. I'll sort that :)

@rossdargan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

I think I need to wait for this pr home-assistant/home-assistant.io#9993 to be approved before I can create the additional documentation for this one.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Ping me when ready.

@rossdargan rossdargan referenced this pull request Aug 6, 2019
2 of 2 tasks complete
@rossdargan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@MartinHjelmare I've added the P/R for the docs now :)

@MartinHjelmare MartinHjelmare removed the core label Aug 6, 2019

@MartinHjelmare MartinHjelmare merged commit 9e8df93 into home-assistant:dev Aug 6, 2019

9 checks passed

CI Build #20190805.38 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

Dev automation moved this from Reviewer approved to Done Aug 6, 2019

@rossdargan rossdargan deleted the rossdargan:add-switch branch Aug 6, 2019

@MartinHjelmare MartinHjelmare referenced this pull request Aug 6, 2019
9 of 9 tasks complete

@lock lock bot locked and limited conversation to collaborators Aug 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.